Bug 217993

Summary: report-non-inclusive-language should do exact match for directory names to ignore
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217972
Bug Depends on:    
Bug Blocks: 213092    
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2020-10-20 15:34:04 PDT
report-non-inclusive-language currently does a substring matching for directory names, and while ignoring a specified directory, e.g.: 'autoinstalled', it would ignore all the directories whose name contains that keyword (e.g.: both 'autoinstalled' and 'notautoinstalled' would be ignored), which is not good. It should do exact match for directory names to ignore.
Attachments
Patch (1.54 KB, patch)
2020-10-20 15:35 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-10-20 15:35:17 PDT
Created attachment 411929 [details] Patch
EWS
Comment 2 2020-10-20 16:14:48 PDT
Committed r268772: <https://trac.webkit.org/changeset/268772> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411929 [details].
Radar WebKit Bug Importer
Comment 3 2020-10-20 16:15:17 PDT
<rdar://problem/70506406>
Note You need to log in before you can comment on or make changes to this bug.