Bug 217984

Summary: [macOS WK1] provide a way for Apple-internal clients to disable link preview
Product: WebKit Reporter: Devin Rousso <hi>
Component: UI EventsAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, eric.carlson, ews-watchlist, glenn, hi, jer.noble, philipj, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2020-10-20 13:33:59 PDT
this should (roughly) match the public `@property BOOL allowsLinkPreview` API on `WKWebView`
Attachments
Patch (4.97 KB, patch)
2020-10-20 14:03 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (4.98 KB, patch)
2020-10-20 14:40 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-10-20 13:34:12 PDT
<rdar://problem/42033485>
Devin Rousso
Comment 2 2020-10-20 13:52:15 PDT
<rdar://problem/70500022>
Devin Rousso
Comment 3 2020-10-20 14:03:30 PDT
Created attachment 411913 [details] Patch
Tim Horton
Comment 4 2020-10-20 14:08:19 PDT
Comment on attachment 411913 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411913&action=review > Source/WebKitLegacy/mac/WebView/WebImmediateActionController.h:61 > +@property (nonatomic) BOOL enabled; getter=isEnabled?
Devin Rousso
Comment 5 2020-10-20 14:40:03 PDT
Created attachment 411918 [details] Patch
EWS
Comment 6 2020-10-21 11:43:38 PDT
Committed r268813: <https://trac.webkit.org/changeset/268813> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411918 [details].
Note You need to log in before you can comment on or make changes to this bug.