Bug 217984

Summary:

[macOS WK1] provide a way for Apple-internal clients to disable link preview

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

UI Events

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, eric.carlson, ews-watchlist, glenn, hi, jer.noble, philipj, sergio, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Devin Rousso 2020-10-20 13:33:59 PDT

this should (roughly) match the public `@property BOOL allowsLinkPreview` API on `WKWebView`

Comment 1 Devin Rousso 2020-10-20 13:34:12 PDT

<rdar://problem/42033485>

Comment 2 Devin Rousso 2020-10-20 13:52:15 PDT

<rdar://problem/70500022>

Comment 3 Devin Rousso 2020-10-20 14:03:30 PDT

Created attachment 411913 [details]
Patch

Comment 4 Tim Horton 2020-10-20 14:08:19 PDT

Comment on attachment 411913 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411913&action=review

> Source/WebKitLegacy/mac/WebView/WebImmediateActionController.h:61
> +@property (nonatomic) BOOL enabled;

getter=isEnabled?

Comment 5 Devin Rousso 2020-10-20 14:40:03 PDT

Created attachment 411918 [details]
Patch

Comment 6 EWS 2020-10-21 11:43:38 PDT

Committed r268813: <https://trac.webkit.org/changeset/268813>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411918 [details].