Bug 217974

Summary: [GStreamer] Create video sink only for video player
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, sergio, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch calvaris: review+

Philippe Normand
Reported 2020-10-20 10:53:36 PDT
.
Attachments
Patch (3.63 KB, patch)
2020-10-20 10:58 PDT, Philippe Normand 		calvaris: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2020-10-20 10:58:07 PDT
Created attachment 411888 [details] Patch
Víctor M. Jáquez L.
Comment 2 2020-10-21 02:36:23 PDT
unofficial lgtm :)
Xabier Rodríguez Calvar
Comment 3 2020-10-21 02:48:06 PDT
Comment on attachment 411888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411888&action=review > Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:320 > - gst_element_register(0, "webkitglvideosink", GST_RANK_PRIMARY, WEBKIT_TYPE_GL_VIDEO_SINK); > + gst_element_register(0, "webkitglvideosink", GST_RANK_NONE, WEBKIT_TYPE_GL_VIDEO_SINK); Why do you need this? > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2732 > + GST_INFO("Creating pipeline for %s player", m_player->isVideoPlayer() ? "video":"audio"); Nit: spaces around :
Philippe Normand
Comment 4 2020-10-21 03:11:29 PDT
Comment on attachment 411888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411888&action=review >> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:320 >> + gst_element_register(0, "webkitglvideosink", GST_RANK_NONE, WEBKIT_TYPE_GL_VIDEO_SINK); > > Why do you need this? Because if we don't give a video-sink to playbin it will create an autovideosink, which, without this change, would create a webkitglvideosink.
Philippe Normand
Comment 5 2020-10-21 03:51:08 PDT
Committed r268790: <https://trac.webkit.org/changeset/268790>
Radar WebKit Bug Importer
Comment 6 2020-10-21 03:52:21 PDT
<rdar://problem/70523722>
Note You need to log in before you can comment on or make changes to this bug.