Bug 217942

Summary:

[JSC] Rename item() to at() and move it behind a flag

Product:

WebKit

Reporter:

Ross Kirsling <ross.kirsling>

Component:

New Bugs

Assignee:

Ross Kirsling <ross.kirsling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Ross Kirsling

Reported 2020-10-19 21:32:26 PDT

[JSC] Rename item() to at() and move it behind a flag

Attachments
Patch (19.68 KB, patch) 2020-10-19 21:40 PDT, Ross Kirsling	no flags	Details Formatted Diff Diff
Patch (20.32 KB, patch) 2020-10-19 22:51 PDT, Ross Kirsling	no flags	Details Formatted Diff Diff
Patch (22.69 KB, patch) 2020-10-19 23:45 PDT, Ross Kirsling	no flags	Details Formatted Diff Diff
Patch (22.14 KB, patch) 2020-10-20 11:46 PDT, Ross Kirsling	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Ross Kirsling

Comment 1 2020-10-19 21:40:26 PDT

Created attachment 411837 [details] Patch

Ross Kirsling

Comment 2 2020-10-19 22:46:41 PDT Comment hidden (obsolete)

Comment on attachment 411837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411837&action=review > Source/JavaScriptCore/runtime/ArrayPrototype.cpp:126 > const Identifier* const unscopableNames[] = { > + &vm.propertyNames->builtinNames().atPublicName(), > &vm.propertyNames->builtinNames().copyWithinPublicName(), Hmm, I'm not exactly sure how I should guard this...

Ross Kirsling

Comment 3 2020-10-19 22:51:40 PDT

Created attachment 411838 [details] Patch

Ross Kirsling

Comment 4 2020-10-19 23:45:31 PDT

Created attachment 411842 [details] Patch

Ross Kirsling

Comment 5 2020-10-20 11:46:54 PDT

Created attachment 411894 [details] Patch

Yusuke Suzuki

Comment 6 2020-10-20 11:52:57 PDT

Comment on attachment 411894 [details] Patch r=me