| Summary: | [JSC] Rename item() to at() and move it behind a flag | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Ross Kirsling
2020-10-19 21:32:26 PDT
Created attachment 411837 [details]
Patch
Comment on attachment 411837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411837&action=review > Source/JavaScriptCore/runtime/ArrayPrototype.cpp:126 > const Identifier* const unscopableNames[] = { > + &vm.propertyNames->builtinNames().atPublicName(), > &vm.propertyNames->builtinNames().copyWithinPublicName(), Hmm, I'm not exactly sure how I should guard this... Created attachment 411838 [details]
Patch
Created attachment 411842 [details]
Patch
Created attachment 411894 [details]
Patch
Comment on attachment 411894 [details]
Patch
r=me
Committed r268760: <https://trac.webkit.org/changeset/268760> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411894 [details]. |