Bug 217927

Summary:	Remove iOS-only NSUserDefaults-backed UA override
Product:	WebKit	Reporter:	Tim Horton <thorton>
Component:	WebCore Misc.	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ahmad.saleem792, a_protyasha, ap, bfulgham, webkit-bug-importer, wenson_hsieh
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Tim Horton 2020-10-19 16:00:23 PDT

We should remove the code in UserAgentIOS.mm that reads an override UA from the NSUserDefault [com.apple.WebFoundation UserAgent].

It is incompatible with the modern need to compose the UA from various bits of information these days (e.g. desktop vs. mobile). Clients should use the API to set the application name or UA instead.

I have stumbled upon one client (com.fark.hey), and there are likely others, so it should be a linked-on-or-after change.

Comment 1 Tim Horton 2020-10-19 16:04:40 PDT

I left a reference here next to the code in https://trac.webkit.org/changeset/268697/webkit

Comment 2 Radar WebKit Bug Importer 2020-10-26 16:01:21 PDT

<rdar://problem/70699433>

Comment 3 Ahmad Saleem 2022-09-12 14:37:01 PDT

Just to update that this FIXME is still present:

https://github.com/WebKit/WebKit/blob/6ead5274db5f92656360fa1fbae3e0091481fc4f/Source/WebCore/platform/ios/UserAgentIOS.mm#L90

Comment 4 Abrar Rahman Protyasha 2023-06-09 00:24:06 PDT

Pull request: https://github.com/WebKit/WebKit/pull/14805

Comment 5 EWS 2023-06-09 14:05:15 PDT

Committed 265034@main (6a68b0c65d6c): <https://commits.webkit.org/265034@main>

Reviewed commits have been landed. Closing PR #14805 and removing active labels.