Bug 217927
| Summary: | Remove iOS-only NSUserDefaults-backed UA override | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ahmad.saleem792, a_protyasha, ap, bfulgham, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Tim Horton
We should remove the code in UserAgentIOS.mm that reads an override UA from the NSUserDefault [com.apple.WebFoundation UserAgent].
It is incompatible with the modern need to compose the UA from various bits of information these days (e.g. desktop vs. mobile). Clients should use the API to set the application name or UA instead.
I have stumbled upon one client (com.fark.hey), and there are likely others, so it should be a linked-on-or-after change.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tim Horton
I left a reference here next to the code in https://trac.webkit.org/changeset/268697/webkit
Radar WebKit Bug Importer
<rdar://problem/70699433>
Ahmad Saleem
Just to update that this FIXME is still present:
https://github.com/WebKit/WebKit/blob/6ead5274db5f92656360fa1fbae3e0091481fc4f/Source/WebCore/platform/ios/UserAgentIOS.mm#L90
Abrar Rahman Protyasha
Pull request: https://github.com/WebKit/WebKit/pull/14805
EWS
Committed 265034@main (6a68b0c65d6c): <https://commits.webkit.org/265034@main>
Reviewed commits have been landed. Closing PR #14805 and removing active labels.