Bug 217911

Summary: [MotionMark] Add state change items to represent changes to stroke and fill state
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebCore Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: sabouhallawa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Wenson Hsieh
Reported 2020-10-19 10:49:03 PDT
SSIA
Attachments
Patch (19.18 KB, patch)
2020-10-19 14:54 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-10-19 14:54:51 PDT
Created attachment 411802 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-10-19 15:44:32 PDT
Comment on attachment 411802 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411802&action=review > Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:409 > + Color m_color; > + float m_thickness { 0 }; > + bool m_hasColor { false }; > + bool m_hasThickness { false }; Are you doing it this way, rather than Optional<>, for better packing?
Wenson Hsieh
Comment 3 2020-10-19 15:45:14 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 411802 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411802&action=review > > > Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:409 > > + Color m_color; > > + float m_thickness { 0 }; > > + bool m_hasColor { false }; > > + bool m_hasThickness { false }; > > Are you doing it this way, rather than Optional<>, for better packing? Yep! (as explained in the ChangeLog)
Wenson Hsieh
Comment 4 2020-10-19 17:30:24 PDT
Comment on attachment 411802 [details] Patch Thanks for the review!
EWS
Comment 5 2020-10-19 17:46:07 PDT
Committed r268704: <https://trac.webkit.org/changeset/268704> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411802 [details].
Radar WebKit Bug Importer
Comment 6 2020-10-19 17:47:18 PDT
<rdar://problem/70464319>
Note You need to log in before you can comment on or make changes to this bug.