Bug 217899

Summary:

Remove the CSSIndividualTransformPropertiesEnabled flag

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

CSS

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ahmad.saleem792, annevk, ap, bfulgham, dino, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, joepeck, macpherson, menard, rniwa, sam, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

216512, 265400

Attachments:

Description	Flags
Patch	none
Patch	simon.fraser: review-, ews-feeder: commit-queue-

Antoine Quint

Reported 2020-10-19 03:21:26 PDT

Now that the default value for this flag is true, we should remove it altogether.

Attachments
Patch (17.80 KB, patch) 2020-10-19 04:46 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch (17.86 KB, patch) 2020-10-20 23:26 PDT, Antoine Quint	simon.fraser: review- ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-10-19 03:21:52 PDT

<rdar://problem/70434096>

Antoine Quint

Comment 2 2020-10-19 04:46:40 PDT

Created attachment 411734 [details] Patch

Simon Fraser (smfr)

Comment 3 2020-10-19 07:31:30 PDT

Comment on attachment 411734 [details] Patch Too soon. We need to be able to turn off for testing, to see what you broke.

Antoine Quint

Comment 4 2020-10-19 07:59:14 PDT

While I'm in no rush to land this, I want to point out that the changes that are actually guarded by that flag are not very risky compared to the GraphicsLayerCA changes that were related to supporting animation of those properties and which are not guarded by that flag (such as r268483).

Antoine Quint

Comment 5 2020-10-20 23:26:46 PDT

Created attachment 411962 [details] Patch

Simon Fraser (smfr)

Comment 6 2020-10-21 10:50:59 PDT

Comment on attachment 411962 [details] Patch We leave flags around for a year for testing.

Sam Weinig

Comment 7 2020-10-21 15:07:29 PDT

(In reply to Simon Fraser (smfr) from comment #6) > Comment on attachment 411962 [details] > Patch > > We leave flags around for a year for testing. Thats not a policy I have heard before. It seems kinda reasonable, though I am a bit unclear its actually useful. If we are going to go with this, it would be nice to make this more official, and have some way of following up (since we have tons of flags that should be removed, but never have been). Can you propose a model for how we can ensure we revisit these after a year?

Ahmad Saleem

Comment 8 2022-08-07 13:33:32 PDT

This one still exists: https://github.com/WebKit/WebKit/blob/12bc2f0ab0d71a2a547031280df9eedf3c536a69/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml#L335

Tim Nguyen (:ntim)

Comment 9 2023-11-26 00:46:29 PST

This is probably removable at this point.

Antoine Quint

Comment 10 2023-11-26 03:29:23 PST

Pull request: https://github.com/WebKit/WebKit/pull/20900

EWS

Comment 11 2023-11-27 00:27:17 PST

Committed 271133@main (3635c66e7e2a): <https://commits.webkit.org/271133@main> Reviewed commits have been landed. Closing PR #20900 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.