Bug 217878

Summary: Remove "lazy offset" optimization from Range to prepare to derive it from SimpleRange
Product: WebKit Reporter: Darin Adler <darin>
Component: DOMAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, esprehn+autocc, ews-watchlist, kangil.han, megan_gardner, rniwa, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Darin Adler
Reported 2020-10-17 13:44:00 PDT
Remove "lazy offset" optmization from Range to prepare to derive it from SimpleRange
Attachments
Patch (6.09 KB, patch)
2020-10-17 13:51 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-10-17 13:51:18 PDT
Created attachment 411675 [details] Patch
Darin Adler
Comment 2 2020-10-17 13:52:50 PDT
Not 100% sure this optimization of Range is important, but it should be relatively simple if I do it a step at a time like this.
Darin Adler
Comment 3 2020-10-17 14:02:18 PDT
I meant to say: "Not 100% sure that re-optimizing Range by making functions like startContainer non-virtual gain is critical"
Darin Adler
Comment 4 2020-10-17 14:07:44 PDT
(In reply to Darin Adler from comment #3) > non-virtual gain again
EWS
Comment 5 2020-10-17 17:48:27 PDT
Committed r268651: <https://trac.webkit.org/changeset/268651> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411675 [details].
Radar WebKit Bug Importer
Comment 6 2020-10-17 17:49:20 PDT
<rdar://problem/70412495>
Note You need to log in before you can comment on or make changes to this bug.