Bug 217877

Summary: Convert preferences in WebPreferencesPrivate.h to use @property syntax to make them more manageable
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch simon.fraser: review+

Sam Weinig
Reported 2020-10-17 10:45:29 PDT
Convert preferences in WebPreferencesPrivate.h to use @property syntax to make them more manageable
Attachments
Patch (27.22 KB, patch)
2020-10-17 10:46 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (27.24 KB, patch)
2020-10-17 10:57 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (27.67 KB, patch)
2020-10-17 10:59 PDT, Sam Weinig 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-10-17 10:46:44 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2020-10-17 10:57:30 PDT Comment hidden (obsolete)
Sam Weinig
Comment 3 2020-10-17 10:59:39 PDT
Created attachment 411673 [details] Patch
Simon Fraser (smfr)
Comment 4 2020-10-17 11:06:32 PDT
Comment on attachment 411673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411673&action=review > Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:259 > +@property (nonatomic, retain) NSArray<NSString *> *additionalSupportedImageTypes; // additionalSupportedImageTypes is an array of image UTIs. Is 'retain' the behavior of the existing code, or should this be 'copy'?
Sam Weinig
Comment 5 2020-10-17 11:09:16 PDT
(In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 411673 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411673&action=review > > > Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:259 > > +@property (nonatomic, retain) NSArray<NSString *> *additionalSupportedImageTypes; // additionalSupportedImageTypes is an array of image UTIs. > > Is 'retain' the behavior of the existing code, or should this be 'copy'? It's the existing behavior (that one was already an @property), but it should probably be copy.
Sam Weinig
Comment 6 2020-10-17 11:28:51 PDT
Committed r268646: <https://trac.webkit.org/changeset/268646>
Radar WebKit Bug Importer
Comment 7 2020-10-17 11:29:15 PDT
<rdar://problem/70409424>
Note You need to log in before you can comment on or make changes to this bug.