Bug 217814

Summary: Implement <forgiving-selector-list> for :is/:where
Product: WebKit Reporter: Anders Ruud <andruud>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cdumez, emilio, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, joepeck, kangil.han, koivisto, macpherson, menard, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: Safari 14   
Hardware: All   
OS: All   
Bug Depends on: 217905, 218009    
Bug Blocks:    
Attachments:
Description Flags
patch
ews-feeder: commit-queue-
patch none

Anders Ruud
Reported 2020-10-16 05:29:43 PDT
The spec now says :is/:where should parse as a forgiving selector list: https://drafts.csswg.org/selectors/#matches
Attachments
patch (30.78 KB, patch)
2020-10-20 03:44 PDT, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch (2.50 MB, patch)
2020-10-20 06:58 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-10-16 11:07:39 PDT
<rdar://problem/70384483>
Antti Koivisto
Comment 2 2020-10-20 03:44:55 PDT
Created attachment 411851 [details] patch
Antti Koivisto
Comment 3 2020-10-20 06:58:53 PDT
Created attachment 411863 [details] patch
Sam Weinig
Comment 4 2020-10-20 09:36:33 PDT
Comment on attachment 411863 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=411863&action=review > Source/WebCore/css/parser/CSSSelectorParser.cpp:95 > + return CSSSelectorList { WTFMove(selectorList) }; I don't think you need to specify CSSSelectorList here if you don't want to.
Antti Koivisto
Comment 5 2020-10-20 09:39:50 PDT
> I don't think you need to specify CSSSelectorList here if you don't want to. I had the same thought but it is marked explicit.
Sam Weinig
Comment 6 2020-10-20 09:45:22 PDT
(In reply to Antti Koivisto from comment #5) > > I don't think you need to specify CSSSelectorList here if you don't want to. > > I had the same thought but it is marked explicit. This is what I get for thinking.
EWS
Comment 7 2020-10-20 10:07:30 PDT
Committed r268741: <https://trac.webkit.org/changeset/268741> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411863 [details].
Note You need to log in before you can comment on or make changes to this bug.