Move even more AudioContext-specific logic out of BaseAudioContext

• Component: Web Audio
• Status: RESOLVED FIXED

[Chris Dumez]

Move even more AudioContext-specific logic out of BaseAudioContext and into AudioContext. In particular, all the logic related to autoplay restrictions, audible state, and platform media session interruptions only apply to AudioContext and not OfflineAudioContext.

[Chris Dumez]

Created attachment 411526 [details]
Patch

[Eric Carlson]

Comment on attachment 411526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411526&action=review

> Source/WebCore/Modules/webaudio/AudioContext.cpp:390
> +            RELEASE_LOG_IF_ALLOWED("visibilityStateChanged() Suspending playback after going to the background");

Any reason to not use `ALWAYS_LOG(LOGIDENTIFIER, ...)` so the output is in the same format as the rest of the logging from this class?

> Source/WebCore/Modules/webaudio/AudioContext.cpp:395
> +            RELEASE_LOG_IF_ALLOWED("visibilityStateChanged() Resuming playback after entering foreground");

Ditto.

[Chris Dumez]

Created attachment 411590 [details]
Patch

[EWS]

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

[Chris Dumez]

Created attachment 411596 [details]
Patch

[EWS]

Committed r268600: <https://trac.webkit.org/changeset/268600>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411596 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70385620>