Bug 217787

Summary: Drop legacy code using AssertionServices
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, darin, ews-watchlist, ggaren, jer.noble, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2020-10-15 14:53:57 PDT
Drop legacy code using AssertionServices as this framework is deprecated in favor of RunningBoard. All our code has been ported to RunningBoard already.
Attachments
Patch (41.35 KB, patch)
2020-10-15 14:57 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (39.72 KB, patch)
2020-10-19 14:11 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (39.72 KB, patch)
2020-10-19 14:28 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-10-15 14:54:14 PDT
<rdar://problem/70160942>
Chris Dumez
Comment 2 2020-10-15 14:57:49 PDT
Created attachment 411495 [details] Patch
Darin Adler
Comment 3 2020-10-15 15:28:57 PDT
Comment on attachment 411495 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411495&action=review > Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:352 > + return m_rbsAssertion ? m_rbsAssertion.get().valid : false; Maybe use &&?
Chris Dumez
Comment 4 2020-10-15 16:31:00 PDT
Hmm. Looks like our iOS EWS is still running iOS 13 and is thus having a bad time... I guess I need to wait until our bots are all upgraded to iOS 14.
Chris Dumez
Comment 5 2020-10-19 14:11:43 PDT
Created attachment 411795 [details] Patch
Darin Adler
Comment 6 2020-10-19 14:27:03 PDT
Comment on attachment 411795 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411795&action=review > Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:352 > + return m_rbsAssertion ? m_rbsAssertion.get().valid : false; Maybe &&
Chris Dumez
Comment 7 2020-10-19 14:27:36 PDT
(In reply to Darin Adler from comment #6) > Comment on attachment 411795 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411795&action=review > > > Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:352 > > + return m_rbsAssertion ? m_rbsAssertion.get().valid : false; > > Maybe && Oh, I missed that. Will fix.
Chris Dumez
Comment 8 2020-10-19 14:28:20 PDT
Created attachment 411800 [details] Patch
EWS
Comment 9 2020-10-20 09:25:48 PDT
Committed r268736: <https://trac.webkit.org/changeset/268736> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411800 [details].
Note You need to log in before you can comment on or make changes to this bug.