Bug 217785

Summary: Refactor {WebAccessibilityObjectWrapper convertRectToSpace] so that the platform-specific code is in their corresponding AX object platform implementations.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andres Gonzalez
Reported 2020-10-15 14:38:13 PDT
Refactor {WebAccessibilityObjectWrapper convertRectToSpace] so that the platform-specific code is in their corresponding AX object platform implementations.
Attachments
Patch (18.45 KB, patch)
2020-10-15 14:55 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (18.40 KB, patch)
2020-10-15 19:31 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2020-10-15 14:55:25 PDT
Created attachment 411492 [details] Patch
chris fleizach
Comment 2 2020-10-15 16:08:56 PDT
Comment on attachment 411492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411492&action=review > Source/WebCore/accessibility/AccessibilityObject.h:444 > + NSView * topDocumentFrameView() const override; * in the wrong place > Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:50 > +NSView * AccessibilityObject::topDocumentFrameView() const * in wrong place > Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:80 > + WAKView* documentView = frameView ? frameView->documentView() : nullptr; * on wrong side > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:583 > + NSView * topDocumentFrameView() const override { return nil; } // FIXME: implement, currently only used on iOS. * wrong place > Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:73 > +NSView * AccessibilityObject::topDocumentFrameView() const * in wrong place > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1983 > + return [NSValue valueWithPoint:NSPointFromCGPoint(cgRect.origin)]; I think you can do return @(cgRect.origin); now
Andres Gonzalez
Comment 3 2020-10-15 19:31:34 PDT
Created attachment 411522 [details] Patch
Andres Gonzalez
Comment 4 2020-10-15 19:34:15 PDT
(In reply to chris fleizach from comment #2) > Comment on attachment 411492 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411492&action=review > > > Source/WebCore/accessibility/AccessibilityObject.h:444 > > + NSView * topDocumentFrameView() const override; > > * in the wrong place Fixed. > > > Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:50 > > +NSView * AccessibilityObject::topDocumentFrameView() const > > * in wrong place Fixed. > > > Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:80 > > + WAKView* documentView = frameView ? frameView->documentView() : nullptr; > > * on wrong side Fixed. > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:583 > > + NSView * topDocumentFrameView() const override { return nil; } // FIXME: implement, currently only used on iOS. > > * wrong place Fixed. > > > Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:73 > > +NSView * AccessibilityObject::topDocumentFrameView() const > > * in wrong place Fixed. > > > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1983 > > + return [NSValue valueWithPoint:NSPointFromCGPoint(cgRect.origin)]; > > I think you can do > > return @(cgRect.origin); > > now Yes, fixed. Thanks.
EWS
Comment 5 2020-10-16 06:03:54 PDT
Committed r268585: <https://trac.webkit.org/changeset/268585> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411522 [details].
Radar WebKit Bug Importer
Comment 6 2020-10-16 06:04:18 PDT
<rdar://problem/70375535>
Note You need to log in before you can comment on or make changes to this bug.