| Summary: | Refactor {WebAccessibilityObjectWrapper convertRectToSpace] so that the platform-specific code is in their corresponding AX object platform implementations. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 411492 [details]
Patch
Comment on attachment 411492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411492&action=review > Source/WebCore/accessibility/AccessibilityObject.h:444 > + NSView * topDocumentFrameView() const override; * in the wrong place > Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:50 > +NSView * AccessibilityObject::topDocumentFrameView() const * in wrong place > Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:80 > + WAKView* documentView = frameView ? frameView->documentView() : nullptr; * on wrong side > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:583 > + NSView * topDocumentFrameView() const override { return nil; } // FIXME: implement, currently only used on iOS. * wrong place > Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:73 > +NSView * AccessibilityObject::topDocumentFrameView() const * in wrong place > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1983 > + return [NSValue valueWithPoint:NSPointFromCGPoint(cgRect.origin)]; I think you can do return @(cgRect.origin); now Created attachment 411522 [details]
Patch
(In reply to chris fleizach from comment #2) > Comment on attachment 411492 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411492&action=review > > > Source/WebCore/accessibility/AccessibilityObject.h:444 > > + NSView * topDocumentFrameView() const override; > > * in the wrong place Fixed. > > > Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:50 > > +NSView * AccessibilityObject::topDocumentFrameView() const > > * in wrong place Fixed. > > > Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:80 > > + WAKView* documentView = frameView ? frameView->documentView() : nullptr; > > * on wrong side Fixed. > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:583 > > + NSView * topDocumentFrameView() const override { return nil; } // FIXME: implement, currently only used on iOS. > > * wrong place Fixed. > > > Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:73 > > +NSView * AccessibilityObject::topDocumentFrameView() const > > * in wrong place Fixed. > > > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1983 > > + return [NSValue valueWithPoint:NSPointFromCGPoint(cgRect.origin)]; > > I think you can do > > return @(cgRect.origin); > > now Yes, fixed. Thanks. Committed r268585: <https://trac.webkit.org/changeset/268585> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411522 [details]. |
Refactor {WebAccessibilityObjectWrapper convertRectToSpace] so that the platform-specific code is in their corresponding AX object platform implementations.