Bug 217760

Summary: [GStreamer] Audio worklet support
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, calvaris, cdumez, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, philipj, sergio, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217699
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Philippe Normand
Reported 2020-10-15 09:47:28 PDT
.
Attachments
Patch (18.75 KB, patch)
2020-10-15 09:52 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (18.79 KB, patch)
2020-10-15 09:53 PDT, Philippe Normand 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2020-10-15 09:52:14 PDT
Created attachment 411447 [details] Patch
EWS Watchlist
Comment 2 2020-10-15 09:53:06 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Philippe Normand
Comment 3 2020-10-15 09:53:25 PDT
Created attachment 411448 [details] Patch
Xabier Rodríguez Calvar
Comment 4 2020-10-16 01:25:31 PDT
Comment on attachment 411448 [details] Patch LGTM but maybe Carlos or anybody else wants to review something more.
Carlos Garcia Campos
Comment 5 2020-10-16 01:45:59 PDT
Comment on attachment 411448 [details] Patch Why do we need a setting for this in the API? Why is it disabled by default?
Philippe Normand
Comment 6 2020-10-16 02:31:05 PDT
(In reply to Carlos Garcia Campos from comment #5) > Comment on attachment 411448 [details] > Patch > > Why do we need a setting for this in the API? Why is it disabled by default? It's an experimental feature, currently. I don't think we want this enabled by default yet.
Carlos Garcia Campos
Comment 7 2020-10-16 04:01:02 PDT
I don't think we should use API settings to expose experimental features.
Philippe Normand
Comment 8 2020-10-16 04:19:31 PDT
Ah, I missed #217708 where this was enabled. Removing the setting then.
Philippe Normand
Comment 9 2020-10-16 04:22:32 PDT
Committed r268579: <https://trac.webkit.org/changeset/268579>
Radar WebKit Bug Importer
Comment 10 2020-10-16 04:23:18 PDT
<rdar://problem/70373484>
Note You need to log in before you can comment on or make changes to this bug.