Bug 217760 - [GStreamer] Audio worklet support
Summary: [GStreamer] Audio worklet support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-15 09:47 PDT by Philippe Normand
Modified: 2020-10-19 05:02 PDT (History)
13 users (show)

See Also:

Attachments
Patch (18.75 KB, patch)
2020-10-15 09:52 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (18.79 KB, patch)
2020-10-15 09:53 PDT, Philippe Normand 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2020-10-15 09:47:28 PDT 
.
Comment 1 Philippe Normand 2020-10-15 09:52:14 PDT 
Created attachment 411447 [details]
Patch
Comment 2 EWS Watchlist 2020-10-15 09:53:06 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Philippe Normand 2020-10-15 09:53:25 PDT 
Created attachment 411448 [details]
Patch
Comment 4 Xabier Rodríguez Calvar 2020-10-16 01:25:31 PDT 
Comment on attachment 411448 [details]
Patch

LGTM but maybe Carlos or anybody else wants to review something more.
Comment 5 Carlos Garcia Campos 2020-10-16 01:45:59 PDT 
Comment on attachment 411448 [details]
Patch

Why do we need a setting for this in the API? Why is it disabled by default?
Comment 6 Philippe Normand 2020-10-16 02:31:05 PDT 
(In reply to Carlos Garcia Campos from comment #5)
> Comment on attachment 411448 [details]
> Patch
> 
> Why do we need a setting for this in the API? Why is it disabled by default?

It's an experimental feature, currently. I don't think we want this enabled by default yet.
Comment 7 Carlos Garcia Campos 2020-10-16 04:01:02 PDT 
I don't think we should use API settings to expose experimental features.
Comment 8 Philippe Normand 2020-10-16 04:19:31 PDT 
Ah, I missed #217708 where this was enabled. Removing the setting then.
Comment 9 Philippe Normand 2020-10-16 04:22:32 PDT 
Committed r268579: <https://trac.webkit.org/changeset/268579>
Comment 10 Radar WebKit Bug Importer 2020-10-16 04:23:18 PDT 
<rdar://problem/70373484>