Bug 217740

Summary: [webkitscmpy] Unconditionally extract git-svn-id from commit message
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215862
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2020-10-14 16:49:56 PDT
Even if a repository is not configured as a git-svn repository, we can occasionally extract and SVN ID.
Attachments
Patch (1.58 KB, patch)
2020-10-14 16:56 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.26 KB, patch)
2020-10-15 10:48 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-10-14 16:51:07 PDT
<rdar://problem/70313868>
Jonathan Bedard
Comment 2 2020-10-14 16:52:12 PDT
I stumbled upon this incidentally, although it's a helpful fact for the WebKit project going forward because we can continue to have tools expose SVN revisions even if the git checkout is not configured as a git-svn checkout.
Jonathan Bedard
Comment 3 2020-10-14 16:56:00 PDT
Created attachment 411388 [details] Patch
Jonathan Bedard
Comment 4 2020-10-15 10:48:58 PDT
Created attachment 411462 [details] Patch for landing
EWS
Comment 5 2020-10-15 11:19:47 PDT
Committed r268538: <https://trac.webkit.org/changeset/268538> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411462 [details].
Note You need to log in before you can comment on or make changes to this bug.