Bug 217740 - [webkitscmpy] Unconditionally extract git-svn-id from commit message
Summary: [webkitscmpy] Unconditionally extract git-svn-id from commit message
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-14 16:49 PDT by Jonathan Bedard
Modified: 2020-10-15 11:19 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.58 KB, patch)
2020-10-14 16:56 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (2.26 KB, patch)
2020-10-15 10:48 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-10-14 16:49:56 PDT
Even if a repository is not configured as a git-svn repository, we can occasionally extract and SVN ID.
Comment 1 Radar WebKit Bug Importer 2020-10-14 16:51:07 PDT
<rdar://problem/70313868>
Comment 2 Jonathan Bedard 2020-10-14 16:52:12 PDT
I stumbled upon this incidentally,  although it's a helpful fact for the WebKit project going forward because we can continue to have tools expose SVN revisions even if the git checkout is not configured as a git-svn checkout.
Comment 3 Jonathan Bedard 2020-10-14 16:56:00 PDT
Created attachment 411388 [details]
Patch
Comment 4 Jonathan Bedard 2020-10-15 10:48:58 PDT
Created attachment 411462 [details]
Patch for landing
Comment 5 EWS 2020-10-15 11:19:47 PDT
Committed r268538: <https://trac.webkit.org/changeset/268538>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411462 [details].