| Summary: | [Testing] Generate test header key map for DumpRenderTree | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annulen, ews-watchlist, gyuyoung.kim, peng.liu6, ryuan.choi, sergio, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Sam Weinig
2020-10-14 11:59:44 PDT
Created attachment 411358 [details]
Patch
Comment on attachment 411358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411358&action=review > Tools/ChangeLog:9 > + to begin support for supporting any WebPreference from DumpRenderTree. This does not actually This change log sounds strange. :-) (In reply to Peng Liu from comment #2) > Comment on attachment 411358 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411358&action=review > > > Tools/ChangeLog:9 > > + to begin support for supporting any WebPreference from DumpRenderTree. This does not actually > > This change log sounds strange. :-) Do you mean just the redundant statement "begin support for supporting"? Or are you referring to something else? Comment on attachment 411358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411358&action=review >>> Tools/ChangeLog:9 >>> + to begin support for supporting any WebPreference from DumpRenderTree. This does not actually >> >> This change log sounds strange. :-) > > Do you mean just the redundant statement "begin support for supporting"? Or are you referring to something else? "begin support for supporting", and "basic test header command key type generation". (In reply to Peng Liu from comment #4) > Comment on attachment 411358 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411358&action=review > > >>> Tools/ChangeLog:9 > >>> + to begin support for supporting any WebPreference from DumpRenderTree. This does not actually > >> > >> This change log sounds strange. :-) > > > > Do you mean just the redundant statement "begin support for supporting"? Or are you referring to something else? > > "begin support for supporting", and "basic test header command key type > generation". The former is mistake. The latter is meaningful. "test header" -> the <!-- webkit-test-runner [ ModernMediaControlsEnabled=true ] --> comments. "command key" -> the name of the commands in those headers, e.g. ModernMediaControlsEnabled Comment on attachment 411358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411358&action=review >>>>> Tools/ChangeLog:9 >>>>> + to begin support for supporting any WebPreference from DumpRenderTree. This does not actually >>>> >>>> This change log sounds strange. :-) >>> >>> Do you mean just the redundant statement "begin support for supporting"? Or are you referring to something else? >> >> "begin support for supporting", and "basic test header command key type generation". > > The former is mistake. The latter is meaningful. > > "test header" -> the <!-- webkit-test-runner [ ModernMediaControlsEnabled=true ] --> comments. > "command key" -> the name of the commands in those headers, e.g. ModernMediaControlsEnabled I see! Thanks! Committed r268495: <https://trac.webkit.org/changeset/268495> Reverted r268495, r268571, and r268682 for reason: Caused failures for some internal build configurations Committed r268693: <https://trac.webkit.org/changeset/268693> Reverted r268693 for reason: Re-landing these changes as the underlying issue may have been with CI infrastructure (and should now be resolved) Committed r268705: <https://trac.webkit.org/changeset/268705> |