Bug 217721

Summary: Non-unified build fixes, mid October 2020
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, cdumez, changseok, dino, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, keith_miller, kondapallykalyan, mark.lam, mmaxfield, msaboff, pdr, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 217734    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Don Olmstead
Reported 2020-10-14 11:51:22 PDT
It's close to midnight And something evil's lurking in the dark Under the moonlight You see a sight that almost stops your heart You try to scream But terror takes the sound before you make it You start to freeze As horror looks you right between the eyes You're paralyzed 'Cause this is thriller, thriller night And no one's gonna save you from the beast about to strike You know it's thriller, thriller night You're fighting for your life inside a killer thriller tonight, yeah
Attachments
Patch (9.52 KB, patch)
2020-10-14 12:10 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (9.52 KB, patch)
2020-10-14 12:14 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (9.56 KB, patch)
2020-10-14 12:25 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-10-14 12:10:37 PDT Comment hidden (obsolete)
Don Olmstead
Comment 2 2020-10-14 12:14:01 PDT
Created attachment 411359 [details] Patch
Yusuke Suzuki
Comment 3 2020-10-14 12:16:17 PDT
Comment on attachment 411359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411359&action=review One comment, the other part looks good to me! > Source/JavaScriptCore/API/JSContextRef.cpp:37 > #include "JSObject.h" Let's remove `"JSObject.h"` since "JSObjectInlines.h" is included.
Don Olmstead
Comment 4 2020-10-14 12:25:24 PDT
Created attachment 411365 [details] Patch
EWS
Comment 5 2020-10-14 13:46:37 PDT
Committed r268485: <https://trac.webkit.org/changeset/268485> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411365 [details].
Radar WebKit Bug Importer
Comment 6 2020-10-14 13:47:19 PDT
<rdar://problem/70306689>
Note You need to log in before you can comment on or make changes to this bug.