Bug 217721 - Non-unified build fixes, mid October 2020
Summary: Non-unified build fixes, mid October 2020
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks: 217734
  Show dependency tree / graph
 
Reported: 2020-10-14 11:51 PDT by Don Olmstead
Modified: 2020-10-14 15:20 PDT (History)
19 users (show)

See Also:

Attachments
Patch (9.52 KB, patch)
2020-10-14 12:10 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (9.52 KB, patch)
2020-10-14 12:14 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (9.56 KB, patch)
2020-10-14 12:25 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-10-14 11:51:22 PDT 
It's close to midnight
And something evil's lurking in the dark
Under the moonlight
You see a sight that almost stops your heart

You try to scream
But terror takes the sound before you make it
You start to freeze
As horror looks you right between the eyes
You're paralyzed

'Cause this is thriller, thriller night
And no one's gonna save you from the beast about to strike
You know it's thriller, thriller night
You're fighting for your life inside a killer thriller tonight, yeah
Comment 1 Don Olmstead 2020-10-14 12:10:37 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2020-10-14 12:14:01 PDT 
Created attachment 411359 [details]
Patch
Comment 3 Yusuke Suzuki 2020-10-14 12:16:17 PDT 
Comment on attachment 411359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411359&action=review

One comment, the other part looks good to me!

> Source/JavaScriptCore/API/JSContextRef.cpp:37
>  #include "JSObject.h"

Let's remove `"JSObject.h"` since "JSObjectInlines.h" is included.
Comment 4 Don Olmstead 2020-10-14 12:25:24 PDT 
Created attachment 411365 [details]
Patch
Comment 5 EWS 2020-10-14 13:46:37 PDT 
Committed r268485: <https://trac.webkit.org/changeset/268485>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411365 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-14 13:47:19 PDT 
<rdar://problem/70306689>