Bug 217711

Summary: Refactor HighlightData
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, changseok, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, mifenton, mmaxfield, pdr, ryuan.choi, sergio, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Megan Gardner
Reported 2020-10-14 09:11:04 PDT
Refactor HighlightData
Attachments
Patch (60.62 KB, patch)
2020-10-14 09:16 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (46.30 KB, patch)
2020-10-14 09:55 PDT, Megan Gardner 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (46.35 KB, patch)
2020-10-14 10:06 PDT, Megan Gardner 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (45.78 KB, patch)
2020-10-14 10:14 PDT, Megan Gardner 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (58.58 KB, patch)
2020-10-14 10:35 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2020-10-14 09:16:30 PDT
Created attachment 411329 [details] Patch
Megan Gardner
Comment 2 2020-10-14 09:55:17 PDT
Created attachment 411338 [details] Patch
Megan Gardner
Comment 3 2020-10-14 10:06:27 PDT
Created attachment 411343 [details] Patch
Megan Gardner
Comment 4 2020-10-14 10:14:20 PDT
Created attachment 411345 [details] Patch
Megan Gardner
Comment 5 2020-10-14 10:35:10 PDT
Created attachment 411347 [details] Patch
Darin Adler
Comment 6 2020-10-14 11:54:02 PDT
Comment on attachment 411347 [details] Patch This looks great. I have some additional ideas for refinement here; HighlightData itself can be simplified further; I’m not sure we even need the concept of RenderRange; we can probably just use SimpleRange instead.
EWS
Comment 7 2020-10-14 13:42:29 PDT
Committed r268484: <https://trac.webkit.org/changeset/268484> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411347 [details].
Radar WebKit Bug Importer
Comment 8 2020-10-14 13:43:21 PDT
<rdar://problem/70306552>
Note You need to log in before you can comment on or make changes to this bug.