| Summary: | Refactor HighlightData | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||||||||
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | annulen, changseok, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, mifenton, mmaxfield, pdr, ryuan.choi, sergio, simon.fraser, thorton, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Megan Gardner
2020-10-14 09:11:04 PDT
Created attachment 411329 [details]
Patch
Created attachment 411338 [details]
Patch
Created attachment 411343 [details]
Patch
Created attachment 411345 [details]
Patch
Created attachment 411347 [details]
Patch
Comment on attachment 411347 [details]
Patch
This looks great. I have some additional ideas for refinement here; HighlightData itself can be simplified further; I’m not sure we even need the concept of RenderRange; we can probably just use SimpleRange instead.
Committed r268484: <https://trac.webkit.org/changeset/268484> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411347 [details]. |