Bug 217710

Summary: Introduce a RemoteAudioSourceProvider to receive audio samples for web audio from GPUProcess
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 217704    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing
none
Patch for landing none

youenn fablet
Reported 2020-10-14 08:35:43 PDT
Introduce a RemoteAudioSourceProvider to receive audio samples for web audio from GPUProcess
Attachments
Patch (38.27 KB, patch)
2020-10-14 08:43 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (38.81 KB, patch)
2020-10-14 08:48 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (40.10 KB, patch)
2020-10-14 09:11 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (41.64 KB, patch)
2020-10-14 09:30 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (62.01 KB, patch)
2020-10-14 23:54 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (61.85 KB, patch)
2020-10-15 03:49 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-10-14 08:43:43 PDT
Created attachment 411326 [details] Patch
youenn fablet
Comment 2 2020-10-14 08:48:13 PDT
Created attachment 411327 [details] Patch
youenn fablet
Comment 3 2020-10-14 09:11:33 PDT
Created attachment 411328 [details] Patch
youenn fablet
Comment 4 2020-10-14 09:30:29 PDT
Created attachment 411331 [details] Patch
Eric Carlson
Comment 5 2020-10-14 12:00:56 PDT
Comment on attachment 411331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411331&action=review > Source/WebCore/ChangeLog:9 > + This allows reusing WebAudioSourceProviderAVFObjC for samples coming from video playback living in GPUProcess. s/video playback/audio playback/ > Source/WebCore/platform/mediastream/mac/MediaStreamTrackAudioSourceProviderAVFObjC.h:36 > +class MediaStreamTrackAudioSourceProviderAVFObjC final Nit: it looks like this class doesn't use AVFoundation, so we could rename it. `MediaStreamTrackAudioSourceProviderCocoa` maybe? > Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.h:54 > +class WEBCORE_EXPORT WebAudioSourceProviderAVFObjC Ditto.
youenn fablet
Comment 6 2020-10-14 23:54:58 PDT
Created attachment 411412 [details] Patch for landing
EWS
Comment 7 2020-10-15 03:00:50 PDT
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
youenn fablet
Comment 8 2020-10-15 03:49:51 PDT
Created attachment 411421 [details] Patch for landing
EWS
Comment 9 2020-10-15 04:36:51 PDT
Committed r268521: <https://trac.webkit.org/changeset/268521> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411421 [details].
Radar WebKit Bug Importer
Comment 10 2020-10-15 04:37:16 PDT
<rdar://problem/70331177>
Note You need to log in before you can comment on or make changes to this bug.