Bug 217706

Summary:

[macOS] Issue sandbox extension to additional icon service when attachment element is enabled.

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	bfulgham: review+
Patch	none

Per Arne Vollan

Reported 2020-10-14 07:03:54 PDT

Issue sandbox extension to 'com.apple.iconservices.store' when attachment element is enabled on macOS.

Attachments
Patch (6.08 KB, patch) 2020-10-14 07:12 PDT, Per Arne Vollan	bfulgham: review+	Details Formatted Diff Diff
Patch (6.59 KB, patch) 2020-10-14 14:44 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-10-14 07:04:16 PDT

<rdar://problem/70291100>

Per Arne Vollan

Comment 2 2020-10-14 07:12:14 PDT

Created attachment 411319 [details] Patch

Brent Fulgham

Comment 3 2020-10-14 14:42:36 PDT

Comment on attachment 411319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411319&action=review r=me > Source/WebKit/UIProcess/WebPageProxy.cpp:7843 > + parameters.attachmentElementExtensionHandles = SandboxExtension::createHandlesForMachLookup(attachmentElementServices(), WTF::nullopt); Much tidier!

Per Arne Vollan

Comment 4 2020-10-14 14:44:52 PDT

Created attachment 411375 [details] Patch

Per Arne Vollan

Comment 5 2020-10-14 14:46:04 PDT

Comment on attachment 411375 [details] Patch Thanks for reviewing!

EWS

Comment 6 2020-10-14 15:19:24 PDT

Committed r268492: <https://trac.webkit.org/changeset/268492> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411375 [details].

Note You need to log in before you can comment on or make changes to this bug.