Bug 217661

Summary: transform-origin is applied on top of invidivual CSS transform properties on composited layers
Product: WebKit Reporter: Antoine Quint <graouts>
Component: CSSAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Antoine Quint
Reported 2020-10-13 11:57:05 PDT
transform-origin is applied on top of invidivual CSS transform properties on composited layers
Attachments
Patch (7.65 KB, patch)
2020-10-13 12:02 PDT, Antoine Quint 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-10-13 11:58:05 PDT
<rdar://problem/70259960>
Antoine Quint
Comment 2 2020-10-13 12:02:11 PDT
Created attachment 411234 [details] Patch
Antoine Quint
Comment 3 2020-10-13 12:02:16 PDT
<rdar://problem/70259960>
Simon Fraser (smfr)
Comment 4 2020-10-13 13:48:54 PDT
Comment on attachment 411234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411234&action=review > Source/WebCore/rendering/style/RenderStyle.cpp:1389 > + bool applyTransformOrigin = options.contains(RenderStyle::TransformOperationOption::TransformOrigin) && (m_rareNonInheritedData->rotate || m_rareNonInheritedData->scale || transformOperations.affectedByTransformOrigin()); m_rareNonInheritedData->rotate and m_rareNonInheritedData->scale may still be no-op values.
Antoine Quint
Comment 5 2020-10-14 00:13:03 PDT
(In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 411234 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411234&action=review > > > Source/WebCore/rendering/style/RenderStyle.cpp:1389 > > + bool applyTransformOrigin = options.contains(RenderStyle::TransformOperationOption::TransformOrigin) && (m_rareNonInheritedData->rotate || m_rareNonInheritedData->scale || transformOperations.affectedByTransformOrigin()); > > m_rareNonInheritedData->rotate and m_rareNonInheritedData->scale may still > be no-op values. I'll add a affectedByTransformOrigin() call for those as well in the commit.
Antoine Quint
Comment 6 2020-10-14 00:17:52 PDT
Committed r268444: <https://trac.webkit.org/changeset/268444>
Note You need to log in before you can comment on or make changes to this bug.