Bug 217661

Summary: transform-origin is applied on top of invidivual CSS transform properties on composited layers
Product: WebKit Reporter: Antoine Quint <graouts>
Component: CSSAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Description Antoine Quint 2020-10-13 11:57:05 PDT 
transform-origin is applied on top of invidivual CSS transform properties on composited layers
Comment 1 Radar WebKit Bug Importer 2020-10-13 11:58:05 PDT 
<rdar://problem/70259960>
Comment 2 Antoine Quint 2020-10-13 12:02:11 PDT 
Created attachment 411234 [details]
Patch
Comment 3 Antoine Quint 2020-10-13 12:02:16 PDT 
<rdar://problem/70259960>
Comment 4 Simon Fraser (smfr) 2020-10-13 13:48:54 PDT 
Comment on attachment 411234 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411234&action=review

> Source/WebCore/rendering/style/RenderStyle.cpp:1389
> +    bool applyTransformOrigin = options.contains(RenderStyle::TransformOperationOption::TransformOrigin) && (m_rareNonInheritedData->rotate || m_rareNonInheritedData->scale || transformOperations.affectedByTransformOrigin());

m_rareNonInheritedData->rotate and m_rareNonInheritedData->scale may still be no-op values.
Comment 5 Antoine Quint 2020-10-14 00:13:03 PDT 
(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 411234 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411234&action=review
> 
> > Source/WebCore/rendering/style/RenderStyle.cpp:1389
> > +    bool applyTransformOrigin = options.contains(RenderStyle::TransformOperationOption::TransformOrigin) && (m_rareNonInheritedData->rotate || m_rareNonInheritedData->scale || transformOperations.affectedByTransformOrigin());
> 
> m_rareNonInheritedData->rotate and m_rareNonInheritedData->scale may still
> be no-op values.

I'll add a affectedByTransformOrigin() call for those as well in the commit.
Comment 6 Antoine Quint 2020-10-14 00:17:52 PDT 
Committed r268444: <https://trac.webkit.org/changeset/268444>