Summary: | [LFC] Use the term overridden instead of override to indicate priority values | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, darin, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
zalan
2020-10-13 09:31:37 PDT
Created attachment 411227 [details]
Patch
Comment on attachment 411227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411227&action=review > Source/WebCore/ChangeLog:8 > + The OverriddenHorizontal/Vertical structures are used to pass in priority values (e.g. use the "max-height" value instead of the computed "height" value) to geometry computation functions. Overridden is still bit vague. Like why? Maybe there are more descriptive terms that could be used for these? (In reply to Antti Koivisto from comment #2) > Comment on attachment 411227 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411227&action=review > > > Source/WebCore/ChangeLog:8 > > + The OverriddenHorizontal/Vertical structures are used to pass in priority values (e.g. use the "max-height" value instead of the computed "height" value) to geometry computation functions. > > Overridden is still bit vague. Like why? Maybe there are more descriptive > terms that could be used for these? Yeah, I agree. Can't think of anything descriptive (and less than 1024 characters long) name right now though. (In reply to zalan from comment #3) > (In reply to Antti Koivisto from comment #2) > > Comment on attachment 411227 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=411227&action=review > > > > > Source/WebCore/ChangeLog:8 > > > + The OverriddenHorizontal/Vertical structures are used to pass in priority values (e.g. use the "max-height" value instead of the computed "height" value) to geometry computation functions. > > > > Overridden is still bit vague. Like why? Maybe there are more descriptive > > terms that could be used for these? > Yeah, I agree. Can't think of anything descriptive (and less than 1024 > characters long) name right now though. The long name would be something like UseTheseValuesForCertainPropertiesInsteadOfTheirComputedValues Committed r268456: <https://trac.webkit.org/changeset/268456> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411227 [details]. |