Summary: | [Testing] Support configuring any preference from test headers for WebKitTestRunner | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | aboxhall, alecflett, annulen, apinheiro, beidson, calvaris, cfleizach, dmazzoni, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, hector_i_lopez, hi, hta, jcraig, jdiggs, jer.noble, jsbell, mkwst, philipj, ryuan.choi, samuel_white, sergio, thorton, tommyw, webkit-bug-importer | ||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Attachments: |
|
Description
Sam Weinig
2020-10-12 18:58:05 PDT
Created attachment 411190 [details]
Patch
Created attachment 411214 [details]
Patch
Created attachment 411217 [details]
Patch
Created attachment 411229 [details]
Patch
Created attachment 411232 [details]
Patch
Aw bummer, still can't use designated initializers due to wincairo. Created attachment 411235 [details]
Patch
Created attachment 411262 [details]
Patch
Ready for review. Committed r268474: <https://trac.webkit.org/changeset/268474> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411262 [details]. Reverted r268474 for reason: Revision is causing a number of test failures across iOS and macOS Committed r268498: <https://trac.webkit.org/changeset/268498> (In reply to Hector Lopez from comment #12) > Reverted r268474 for reason: > > Revision is causing a number of test failures across iOS and macOS > > Committed r268498: <https://trac.webkit.org/changeset/268498> Details in https://bugs.webkit.org/show_bug.cgi?id=217731 Created attachment 411588 [details]
Patch
Committed r268604: <https://trac.webkit.org/changeset/268604> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411588 [details]. |