Bug 217645

Summary: [Testing] Support configuring any preference from test headers for WebKitTestRunner
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, alecflett, annulen, apinheiro, beidson, calvaris, cfleizach, dmazzoni, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, hector_i_lopez, hi, hta, jcraig, jdiggs, jer.noble, jsbell, mkwst, philipj, ryuan.choi, samuel_white, sergio, thorton, tommyw, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Sam Weinig 2020-10-12 18:58:05 PDT
[Testing] Support configuring any preference from test headers for WebKitTestRunner
Comment 1 Sam Weinig 2020-10-12 19:19:54 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-10-13 06:32:40 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-10-13 07:36:45 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-10-13 11:10:48 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2020-10-13 11:51:51 PDT Comment hidden (obsolete)
Comment 6 Sam Weinig 2020-10-13 12:04:04 PDT Comment hidden (obsolete)
Comment 7 Sam Weinig 2020-10-13 12:10:37 PDT Comment hidden (obsolete)
Comment 8 Sam Weinig 2020-10-13 14:54:08 PDT
Created attachment 411262 [details]
Patch
Comment 9 Sam Weinig 2020-10-13 21:11:41 PDT
Ready for review.
Comment 10 EWS 2020-10-14 10:56:16 PDT
Committed r268474: <https://trac.webkit.org/changeset/268474>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411262 [details].
Comment 11 Radar WebKit Bug Importer 2020-10-14 10:57:18 PDT
<rdar://problem/70299567>
Comment 12 Hector Lopez 2020-10-14 16:21:15 PDT
Reverted r268474 for reason:

Revision is causing a number of test failures across iOS and macOS

Committed r268498: <https://trac.webkit.org/changeset/268498>
Comment 13 Ryan Haddad 2020-10-14 16:27:25 PDT
(In reply to Hector Lopez from comment #12)
> Reverted r268474 for reason:
> 
> Revision is causing a number of test failures across iOS and macOS
> 
> Committed r268498: <https://trac.webkit.org/changeset/268498>
Details in https://bugs.webkit.org/show_bug.cgi?id=217731
Comment 14 Sam Weinig 2020-10-16 09:43:55 PDT
Created attachment 411588 [details]
Patch
Comment 15 EWS 2020-10-16 12:37:11 PDT
Committed r268604: <https://trac.webkit.org/changeset/268604>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411588 [details].