Bug 217645

Summary:

[Testing] Support configuring any preference from test headers for WebKitTestRunner

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, alecflett, annulen, apinheiro, beidson, calvaris, cfleizach, dmazzoni, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, hector_i_lopez, hi, hta, jcraig, jdiggs, jer.noble, jsbell, mkwst, philipj, ryuan.choi, samuel_white, sergio, thorton, tommyw, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none

Sam Weinig

Reported 2020-10-12 18:58:05 PDT

[Testing] Support configuring any preference from test headers for WebKitTestRunner

Attachments
Patch (366.97 KB, patch) 2020-10-12 19:19 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (366.41 KB, patch) 2020-10-13 06:32 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (366.48 KB, patch) 2020-10-13 07:36 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (22.84 KB, patch) 2020-10-13 11:10 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (35.28 KB, patch) 2020-10-13 11:51 PDT, Sam Weinig	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (35.37 KB, patch) 2020-10-13 12:10 PDT, Sam Weinig	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (34.33 KB, patch) 2020-10-13 14:54 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (39.68 KB, patch) 2020-10-16 09:43 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2020-10-12 19:19:54 PDT Comment hidden (obsolete)

Created attachment 411190 [details] Patch

Sam Weinig

Comment 2 2020-10-13 06:32:40 PDT Comment hidden (obsolete)

Created attachment 411214 [details] Patch

Sam Weinig

Comment 3 2020-10-13 07:36:45 PDT Comment hidden (obsolete)

Created attachment 411217 [details] Patch

Sam Weinig

Comment 4 2020-10-13 11:10:48 PDT Comment hidden (obsolete)

Created attachment 411229 [details] Patch

Sam Weinig

Comment 5 2020-10-13 11:51:51 PDT Comment hidden (obsolete)

Created attachment 411232 [details] Patch

Sam Weinig

Comment 6 2020-10-13 12:04:04 PDT Comment hidden (obsolete)

Aw bummer, still can't use designated initializers due to wincairo.

Sam Weinig

Comment 7 2020-10-13 12:10:37 PDT Comment hidden (obsolete)

Created attachment 411235 [details] Patch

Sam Weinig

Comment 8 2020-10-13 14:54:08 PDT

Created attachment 411262 [details] Patch

Sam Weinig

Comment 9 2020-10-13 21:11:41 PDT

Ready for review.

EWS

Comment 10 2020-10-14 10:56:16 PDT

Committed r268474: <https://trac.webkit.org/changeset/268474> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411262 [details].

Radar WebKit Bug Importer

Comment 11 2020-10-14 10:57:18 PDT

<rdar://problem/70299567>

Hector Lopez

Comment 12 2020-10-14 16:21:15 PDT

Reverted r268474 for reason: Revision is causing a number of test failures across iOS and macOS Committed r268498: <https://trac.webkit.org/changeset/268498>

Ryan Haddad

Comment 13 2020-10-14 16:27:25 PDT

(In reply to Hector Lopez from comment #12) > Reverted r268474 for reason: > > Revision is causing a number of test failures across iOS and macOS > > Committed r268498: <https://trac.webkit.org/changeset/268498> Details in https://bugs.webkit.org/show_bug.cgi?id=217731

Sam Weinig

Comment 14 2020-10-16 09:43:55 PDT

Created attachment 411588 [details] Patch

EWS

Comment 15 2020-10-16 12:37:11 PDT

Committed r268604: <https://trac.webkit.org/changeset/268604> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411588 [details].

Note You need to log in before you can comment on or make changes to this bug.