Bug 217633

Summary: Clean up the API tests of CARingBuffer
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: New BugsAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Revise the patch according to Sam's comment none

Peng Liu
Reported 2020-10-12 14:15:59 PDT
Clean up the API tests of CARingBuffer
Attachments
Patch (2.48 KB, patch)
2020-10-12 14:18 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Revise the patch according to Sam's comment (2.50 KB, patch)
2020-10-12 15:41 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peng Liu
Comment 1 2020-10-12 14:18:18 PDT
Created attachment 411157 [details] Patch
Sam Weinig
Comment 2 2020-10-12 14:53:01 PDT
Comment on attachment 411157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411157&action=review > Tools/TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:28 > +#if PLATFORM(COCOA) Maybe HAVE(CORE_AUDIO) or HAVE(AUDIO_TOOLBOX) instead?
Peng Liu
Comment 3 2020-10-12 15:25:11 PDT
Comment on attachment 411157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411157&action=review >> Tools/TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:28 >> +#if PLATFORM(COCOA) > > Maybe HAVE(CORE_AUDIO) or HAVE(AUDIO_TOOLBOX) instead? Yes, good point! Thanks!
Peng Liu
Comment 4 2020-10-12 15:41:59 PDT
Created attachment 411176 [details] Revise the patch according to Sam's comment
EWS
Comment 5 2020-10-13 09:56:42 PDT
Committed r268397: <https://trac.webkit.org/changeset/268397> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411176 [details].
Radar WebKit Bug Importer
Comment 6 2020-10-13 09:57:15 PDT
<rdar://problem/70256224>
Note You need to log in before you can comment on or make changes to this bug.