Bug 217603

Summary: Remove ACCELERATED_2D_CANVAS build flags and guarded code
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, calvaris, cdumez, cgarcia, changseok, cmarcelo, dino, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, glenn, graouts, gustavo, gyuyoung.kim, jbedard, jer.noble, kondapallykalyan, mcatanzaro, menard, mmaxfield, pdr, philipj, pnormand, quequotion, ryuan.choi, sergio, simon.fraser, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=207048
Attachments:
Description Flags
WIP
none
Patch
none
Patch for landing none

Zan Dobersek
Reported 2020-10-12 02:01:33 PDT
Remove ACCELERATED_2D_CANVAS build flags and guarded code
Attachments
WIP (66.63 KB, patch)
2020-10-12 02:02 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (78.06 KB, patch)
2020-10-12 11:40 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (78.15 KB, patch)
2020-10-13 04:29 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2020-10-12 02:02:13 PDT
Created attachment 411104 [details] WIP
Konstantin Tokarev
Comment 2 2020-10-12 03:30:41 PDT
It would be great if there was some justification in changelog, as it's not removing obviously dead code
Zan Dobersek
Comment 3 2020-10-12 11:40:04 PDT
Created attachment 411138 [details] Patch
Carlos Garcia Campos
Comment 4 2020-10-13 01:12:29 PDT
Comment on attachment 411138 [details] Patch I guess this needs to be rebased
Zan Dobersek
Comment 5 2020-10-13 04:29:10 PDT
Created attachment 411210 [details] Patch for landing
Michael Catanzaro
Comment 6 2020-10-13 07:23:57 PDT
(In reply to Konstantin Tokarev from comment #2) > It would be great if there was some justification in changelog, as it's not > removing obviously dead code The updated changelog looks better. Also note it's been disabled by default everywhere since bug #148473. Probably long past time to remove it.
Adrian Perez
Comment 7 2020-10-13 07:53:37 PDT
*** Bug 208523 has been marked as a duplicate of this bug. ***
Zan Dobersek
Comment 8 2020-10-14 05:06:35 PDT
Comment on attachment 411210 [details] Patch for landing Clearing flags on attachment: 411210 Committed r268453: <https://trac.webkit.org/changeset/268453>
Zan Dobersek
Comment 9 2020-10-14 05:06:40 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2020-10-14 05:07:19 PDT
<rdar://problem/70288514>
Note You need to log in before you can comment on or make changes to this bug.