Bug 217603

Summary: Remove ACCELERATED_2D_CANVAS build flags and guarded code
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, calvaris, cdumez, cgarcia, changseok, cmarcelo, dino, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, glenn, graouts, gustavo, gyuyoung.kim, jbedard, jer.noble, kondapallykalyan, mcatanzaro, menard, mmaxfield, pdr, philipj, pnormand, quequotion, ryuan.choi, sergio, simon.fraser, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=207048
Attachments:
Description Flags
WIP
none
Patch
none
Patch for landing none

Description Zan Dobersek 2020-10-12 02:01:33 PDT
Remove ACCELERATED_2D_CANVAS build flags and guarded code
Comment 1 Zan Dobersek 2020-10-12 02:02:13 PDT
Created attachment 411104 [details]
WIP
Comment 2 Konstantin Tokarev 2020-10-12 03:30:41 PDT
It would be great if there was some justification in changelog, as it's not removing obviously dead code
Comment 3 Zan Dobersek 2020-10-12 11:40:04 PDT
Created attachment 411138 [details]
Patch
Comment 4 Carlos Garcia Campos 2020-10-13 01:12:29 PDT
Comment on attachment 411138 [details]
Patch

I guess this needs to be rebased
Comment 5 Zan Dobersek 2020-10-13 04:29:10 PDT
Created attachment 411210 [details]
Patch for landing
Comment 6 Michael Catanzaro 2020-10-13 07:23:57 PDT
(In reply to Konstantin Tokarev from comment #2)
> It would be great if there was some justification in changelog, as it's not
> removing obviously dead code

The updated changelog looks better. Also note it's been disabled by default everywhere since bug #148473. Probably long past time to remove it.
Comment 7 Adrian Perez 2020-10-13 07:53:37 PDT
*** Bug 208523 has been marked as a duplicate of this bug. ***
Comment 8 Zan Dobersek 2020-10-14 05:06:35 PDT
Comment on attachment 411210 [details]
Patch for landing

Clearing flags on attachment: 411210

Committed r268453: <https://trac.webkit.org/changeset/268453>
Comment 9 Zan Dobersek 2020-10-14 05:06:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2020-10-14 05:07:19 PDT
<rdar://problem/70288514>