Bug 217602

Summary: [macOS] Workaround for MAC_OS_X_VERSION_MAJOR incorrectly including minor version when building with Xcode 12 on macOS Big Sur SUs
Product: WebKit Reporter: Luming Yin <luming_yin>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, dino, eric.carlson, ews-watchlist, graouts, hi, jbedard, keith_miller, kondapallykalyan, mark.lam, msaboff, rniwa, saam, tzagallo, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Mac   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Luming Yin 2020-10-11 23:56:47 PDT 
<rdar://problem/70194453>
Comment 1 Luming Yin 2020-10-12 00:04:06 PDT 
Created attachment 411097 [details]
Patch
Comment 2 EWS Watchlist 2020-10-12 00:05:24 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Luming Yin 2020-10-12 00:58:36 PDT 
Created attachment 411100 [details]
Patch
Comment 4 EWS 2020-10-12 09:27:23 PDT 
Committed r268353: <https://trac.webkit.org/changeset/268353>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411100 [details].
Comment 5 Luming Yin 2020-10-12 14:05:04 PDT 
This needs another patch. Reopening.
Comment 6 Luming Yin 2020-10-12 14:14:46 PDT 
Created attachment 411156 [details]
Patch
Comment 7 Darin Adler 2020-10-12 14:35:53 PDT 
Comment on attachment 411156 [details]
Patch

Ah, so my question wasn’t so pointless after all!
Comment 8 Luming Yin 2020-10-12 15:08:15 PDT 
(In reply to Darin Adler from comment #7)
> Comment on attachment 411156 [details]
> Patch
> 
> Ah, so my question wasn’t so pointless after all!

Indeed!
Comment 9 EWS 2020-10-12 15:09:41 PDT 
Committed r268371: <https://trac.webkit.org/changeset/268371>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411156 [details].