Bug 217601

Summary: [LFC Display] Introduce BoxModelBox, and clarify some naming
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
zalan: review+
Patch none

Simon Fraser (smfr)
Reported 2020-10-11 20:53:22 PDT
[LFC Display] Introduce BoxModelBox, and clarify some naming
Attachments
Patch (26.43 KB, patch)
2020-10-11 20:56 PDT, Simon Fraser (smfr) 		zalan: review+
DetailsFormatted DiffDiff
Patch (27.29 KB, patch)
2020-10-11 21:17 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-10-11 20:56:04 PDT
Created attachment 411094 [details] Patch
alan
Comment 2 2020-10-11 21:01:50 PDT
Comment on attachment 411094 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411094&action=review > Source/WebCore/display/css/DisplayBoxModelBox.cpp:2 > + * Copyright (C) 2018 Apple Inc. All rights reserved. 2020? > Source/WebCore/display/css/DisplayBoxModelBox.h:2 > + * Copyright (C) 2018 Apple Inc. All rights reserved. 2020?
Simon Fraser (smfr)
Comment 3 2020-10-11 21:17:19 PDT
Created attachment 411095 [details] Patch
EWS
Comment 4 2020-10-12 08:04:17 PDT
commit-queue failed to commit attachment 411095 [details] to WebKit repository.
EWS
Comment 5 2020-10-12 10:03:15 PDT
Committed r268355: <https://trac.webkit.org/changeset/268355> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411095 [details].
Radar WebKit Bug Importer
Comment 6 2020-10-12 10:04:23 PDT
<rdar://problem/70211748>
Simon Fraser (smfr)
Comment 7 2020-11-27 10:10:57 PST
*** Bug 217600 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.