Bug 217601 - [LFC Display] Introduce BoxModelBox, and clarify some naming
Summary: [LFC Display] Introduce BoxModelBox, and clarify some naming
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
: 217600 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-10-11 20:53 PDT by Simon Fraser (smfr)
Modified: 2020-11-27 10:10 PST (History)
4 users (show)

See Also:

Attachments
Patch (26.43 KB, patch)
2020-10-11 20:56 PDT, Simon Fraser (smfr) 		zalan: review+
Details | Formatted Diff | Diff
Patch (27.29 KB, patch)
2020-10-11 21:17 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-10-11 20:53:22 PDT 
[LFC Display] Introduce BoxModelBox, and clarify some naming
Comment 1 Simon Fraser (smfr) 2020-10-11 20:56:04 PDT 
Created attachment 411094 [details]
Patch
Comment 2 zalan 2020-10-11 21:01:50 PDT 
Comment on attachment 411094 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411094&action=review

> Source/WebCore/display/css/DisplayBoxModelBox.cpp:2
> + * Copyright (C) 2018 Apple Inc. All rights reserved.

2020?

> Source/WebCore/display/css/DisplayBoxModelBox.h:2
> + * Copyright (C) 2018 Apple Inc. All rights reserved.

2020?
Comment 3 Simon Fraser (smfr) 2020-10-11 21:17:19 PDT 
Created attachment 411095 [details]
Patch
Comment 4 EWS 2020-10-12 08:04:17 PDT 
commit-queue failed to commit attachment 411095 [details] to WebKit repository.
Comment 5 EWS 2020-10-12 10:03:15 PDT 
Committed r268355: <https://trac.webkit.org/changeset/268355>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411095 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-12 10:04:23 PDT 
<rdar://problem/70211748>
Comment 7 Simon Fraser (smfr) 2020-11-27 10:10:57 PST 
*** Bug 217600 has been marked as a duplicate of this bug. ***