Bug 21759

Summary:

Layering violation: FileChooser should not depend on Document/Frame/Page

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

21354

Attachments:

Description	Flags
WIP patch	none
patch	mitz: review+

Description Sam Weinig 2008-10-20 14:19:47 PDT

It is a layering violation for FileChooser to depend on Document, Frame and Page.

Comment 1 Sam Weinig 2008-10-20 14:21:17 PDT

Created attachment 24530 [details]
WIP patch

Adele is working on changes to the FileChooser, so this patch may not apply cleanly after she is done.  I will fix it up and attach a new one when she lands.

Comment 2 Sam Weinig 2008-10-24 18:56:31 PDT

Created attachment 24667 [details]
patch

Comment 3 mitz 2008-10-24 21:39:35 PDT

Comment on attachment 24667 [details]
patch

r=me. Please remove the old Gtk code.

Comment 4 Sam Weinig 2008-10-24 23:02:31 PDT

Landed in r37880.