Summary: | [GPU Process][Resource caching 5/7]: Clean the DisplayList recording of the NativeImage | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||||||||
Component: | Layout and Rendering | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | annulen, bfulgham, calvaris, cdumez, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, gyuyoung.kim, japhet, jer.noble, menard, philipj, pnormand, ryuan.choi, sergio, simon.fraser, vjaquez, webkit-bug-importer, zalan | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 217566 | ||||||||||||||
Bug Blocks: | 217342, 217596 | ||||||||||||||
Attachments: |
|
Description
Said Abou-Hallawa
2020-10-11 01:44:41 PDT
Created attachment 411041 [details]
Patch
Created attachment 411042 [details]
Patch
Created attachment 411044 [details]
Patch for review
Created attachment 411660 [details]
Patch
Created attachment 411662 [details]
Patch
Comment on attachment 411662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411662&action=review > Source/WebCore/platform/graphics/BitmapImage.cpp:218 > + // Subsampling may have given us an image that is smaller than size(). > + IntSize subsampledImageSize = nativeImageSize(image); > + if (options.orientation().usesWidthAsHeight()) > + subsampledImageSize = subsampledImageSize.transposedSize(); > + > + // srcRect is in the coordinates of the unsubsampled image, so we have to map it to the subsampled image. > + FloatRect adjustedSrcRect = srcRect; > + if (subsampledImageSize != srcSize) > + adjustedSrcRect = mapRect(srcRect, FloatRect({ }, srcSize), FloatRect({ }, subsampledImageSize)); What justifies this code being here and not inside GraphicsContext::drawNativeImage? Comment on attachment 411662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411662&action=review >> Source/WebCore/platform/graphics/BitmapImage.cpp:218 >> + adjustedSrcRect = mapRect(srcRect, FloatRect({ }, srcSize), FloatRect({ }, subsampledImageSize)); > > What justifies this code being here and not inside GraphicsContext::drawNativeImage? I will move this code to GraphicsContext::drawNativeImage() in bug 217596. Committed r268669: <https://trac.webkit.org/changeset/268669> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411662 [details]. |