| Summary: | REGRESSION (r37712): Windows JSC build broken (can't return JSValuePtr from ctiTrampoline, which is extern "C") | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Blocker | CC: | darin | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Attachments: |
|
||||||
Build is probably fixed by http://trac.webkit.org/changeset/37721 but compiling isn't enough -- not sure the CTI code still works properly. Created attachment 24524 [details]
patch to fix so it actually runs, not just compiles
Comment on attachment 24524 [details]
patch to fix so it actually runs, not just compiles
r=me
|
The Windows JSC build is broken. Here's the error: c:\cygwin\home\adam roben\dev\webkit\opensource\javascriptcore\vm\CTI.h(233) : warning C4190: 'ctiTrampoline' has C-linkage specified, but returns UDT 'JSC::JSValuePtr' which is incompatible with C c:\cygwin\home\adam roben\dev\webkit\opensource\javascriptcore\kjs\JSImmediate.h(42) : see declaration of 'JSC::JSValuePtr' r37712 <http://trac.webkit.org/changeset/37712> changed JSValuePtr from a JSValue* typedef to a class. We could roll out r37712 (and r37714, which depends upon it). But hopefully there's a better fix!