Bug 21754

Summary: REGRESSION (r37712): Windows JSC build broken (can't return JSValuePtr from ctiTrampoline, which is extern "C")
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Blocker CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
patch to fix so it actually runs, not just compiles ggaren: review+

Adam Roben (:aroben)
Reported 2008-10-20 08:16:43 PDT
The Windows JSC build is broken. Here's the error: c:\cygwin\home\adam roben\dev\webkit\opensource\javascriptcore\vm\CTI.h(233) : warning C4190: 'ctiTrampoline' has C-linkage specified, but returns UDT 'JSC::JSValuePtr' which is incompatible with C c:\cygwin\home\adam roben\dev\webkit\opensource\javascriptcore\kjs\JSImmediate.h(42) : see declaration of 'JSC::JSValuePtr' r37712 <http://trac.webkit.org/changeset/37712> changed JSValuePtr from a JSValue* typedef to a class. We could roll out r37712 (and r37714, which depends upon it). But hopefully there's a better fix!
Attachments
patch to fix so it actually runs, not just compiles (44.82 KB, patch)
2008-10-20 09:13 PDT, Darin Adler 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2008-10-20 08:20:31 PDT
Build is probably fixed by http://trac.webkit.org/changeset/37721 but compiling isn't enough -- not sure the CTI code still works properly.
Darin Adler
Comment 2 2008-10-20 09:13:54 PDT
Created attachment 24524 [details] patch to fix so it actually runs, not just compiles
Geoffrey Garen
Comment 3 2008-10-20 09:17:09 PDT
Comment on attachment 24524 [details] patch to fix so it actually runs, not just compiles r=me
Note You need to log in before you can comment on or make changes to this bug.