Bug 217539 – [GPU Process] Mechanical cleanup in DisplayListRecorder

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

[GPU Process] Mechanical cleanup in DisplayListRecorder

[Myles C. Maxfield]

Created attachment 410980 [details]
Patch

[Sam Weinig]

Comment on attachment 410980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410980&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:381
> +    DrawingItem& newItem = downcast<DrawingItem>(appendItem(WTFMove(item)));
> +    updateItemExtent(newItem);

auto would good here.

If you wanted to, I would also consider making Recorder::appendItem a template function so that the downcast is not needed for callers of appendItem.

template<typename ItemType>
ItemType& Recorder::appendItem(Ref<ItemType>&& item)
{
    willAppendItem(item.get());
    return downcast<ItemType>(m_displayList.append(WTFMove(item)));
}

[Myles C. Maxfield]

Created attachment 410982 [details]
Patch for committing

[EWS]

Committed r268300: <https://trac.webkit.org/changeset/268300>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410982 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70159802>