Bug 217508

Summary: Implement TCC checks in UserMediaPermissionRequestManagerProxy
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

youenn fablet
Reported 2020-10-09 00:52:44 PDT
Implement TCC checks in UserMediaPermissionRequestManagerProxy
Attachments
Patch (16.96 KB, patch)
2020-10-09 01:05 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (16.96 KB, patch)
2020-10-09 01:29 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (17.22 KB, patch)
2020-10-09 05:18 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-10-09 00:53:02 PDT
<rdar://problem/70129993>
youenn fablet
Comment 2 2020-10-09 01:05:36 PDT
Created attachment 410923 [details] Patch
youenn fablet
Comment 3 2020-10-09 01:29:02 PDT
Created attachment 410924 [details] Patch
youenn fablet
Comment 4 2020-10-09 05:18:48 PDT
Created attachment 410935 [details] Patch
Eric Carlson
Comment 5 2020-10-09 07:00:57 PDT
Comment on attachment 410935 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410935&action=review > Source/WebKit/UIProcess/Cocoa/UserMediaPermissionRequestManagerProxy.mm:155 > + auto completionHandler = requiresVideoTCCPrompt ? [request = makeRef(request), callback = WTFMove(callback)](bool isOK) mutable { > + if (!isOK) { > + callback(false); > + return; > + } > + requestAVCaptureAccessForMediaType(WTFMove(callback), AVMediaTypeVideo); > + } : WTFMove(callback); Very nice!
EWS
Comment 6 2020-10-09 07:06:28 PDT
Committed r268256: <https://trac.webkit.org/changeset/268256> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410935 [details].
Note You need to log in before you can comment on or make changes to this bug.