Bug 217508 - Implement TCC checks in UserMediaPermissionRequestManagerProxy
Summary: Implement TCC checks in UserMediaPermissionRequestManagerProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-09 00:52 PDT by youenn fablet
Modified: 2020-10-09 07:06 PDT (History)
8 users (show)

See Also:

Attachments
Patch (16.96 KB, patch)
2020-10-09 01:05 PDT, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (16.96 KB, patch)
2020-10-09 01:29 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (17.22 KB, patch)
2020-10-09 05:18 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-10-09 00:52:44 PDT 
Implement TCC checks in UserMediaPermissionRequestManagerProxy
Comment 1 Radar WebKit Bug Importer 2020-10-09 00:53:02 PDT 
<rdar://problem/70129993>
Comment 2 youenn fablet 2020-10-09 01:05:36 PDT 
Created attachment 410923 [details]
Patch
Comment 3 youenn fablet 2020-10-09 01:29:02 PDT 
Created attachment 410924 [details]
Patch
Comment 4 youenn fablet 2020-10-09 05:18:48 PDT 
Created attachment 410935 [details]
Patch
Comment 5 Eric Carlson 2020-10-09 07:00:57 PDT 
Comment on attachment 410935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410935&action=review

> Source/WebKit/UIProcess/Cocoa/UserMediaPermissionRequestManagerProxy.mm:155
> +    auto completionHandler = requiresVideoTCCPrompt ? [request = makeRef(request), callback = WTFMove(callback)](bool isOK) mutable {
> +        if (!isOK) {
> +            callback(false);
> +            return;
> +        }
> +        requestAVCaptureAccessForMediaType(WTFMove(callback), AVMediaTypeVideo);
> +    } : WTFMove(callback);

Very nice!
Comment 6 EWS 2020-10-09 07:06:28 PDT 
Committed r268256: <https://trac.webkit.org/changeset/268256>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410935 [details].