Bug 217504

Summary: [GLIB] Fix tests compilation warnings with deprecated API
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: New BugsAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216927
Attachments:
Description Flags
Patch
none
Patch for landing none

Lauro Moura
Reported 2020-10-08 19:48:50 PDT
[GLIB] Fix tests compilation warnings with deprecated API
Attachments
Patch (1.86 KB, patch)
2020-10-08 19:50 PDT, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.88 KB, patch)
2020-10-09 04:53 PDT, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2020-10-08 19:50:18 PDT
Created attachment 410903 [details] Patch
Carlos Garcia Campos
Comment 2 2020-10-08 23:15:53 PDT
Comment on attachment 410903 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410903&action=review > Tools/TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:443 > + auto* websiteDataManager = webkit_web_view_get_website_data_manager(m_webView); > + webkit_website_data_manager_set_network_proxy_settings(websiteDataManager, WEBKIT_NETWORK_PROXY_MODE_CUSTOM, settings); It doesn't matter in this case because it's the same, but I would get the data manager from the context instead.
Lauro Moura
Comment 3 2020-10-09 04:53:37 PDT
Created attachment 410933 [details] Patch for landing
EWS
Comment 4 2020-10-09 08:33:26 PDT
Committed r268258: <https://trac.webkit.org/changeset/268258> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410933 [details].
Radar WebKit Bug Importer
Comment 5 2020-10-09 08:34:19 PDT
<rdar://problem/70139759>
Note You need to log in before you can comment on or make changes to this bug.