Bug 217504

Summary: [GLIB] Fix tests compilation warnings with deprecated API
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: New BugsAssignee: Lauro Moura <lmoura>
Severity: Normal CC: bugs-noreply, cgarcia, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216927
Description Flags
Patch for landing none

Description Lauro Moura 2020-10-08 19:48:50 PDT
[GLIB] Fix tests compilation warnings with deprecated API
Comment 1 Lauro Moura 2020-10-08 19:50:18 PDT
Created attachment 410903 [details]
Comment 2 Carlos Garcia Campos 2020-10-08 23:15:53 PDT
Comment on attachment 410903 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=410903&action=review

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:443
> +        auto* websiteDataManager = webkit_web_view_get_website_data_manager(m_webView);
> +        webkit_website_data_manager_set_network_proxy_settings(websiteDataManager, WEBKIT_NETWORK_PROXY_MODE_CUSTOM, settings);

It doesn't matter in this case because it's the same, but I would get the data manager from the context instead.
Comment 3 Lauro Moura 2020-10-09 04:53:37 PDT
Created attachment 410933 [details]
Patch for landing
Comment 4 EWS 2020-10-09 08:33:26 PDT
Committed r268258: <https://trac.webkit.org/changeset/268258>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410933 [details].
Comment 5 Radar WebKit Bug Importer 2020-10-09 08:34:19 PDT