Bug 217491

Summary: [GPU Process] Use correct GPU runtime settings when creating the dynamic IOKit sandbox extensions for the WebContent process
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
youennf: review+
Patch none

Per Arne Vollan
Reported 2020-10-08 13:28:14 PDT
Currently, the creation of the dynamic IOKit sandbox extensions for the WebContent process is incorrectly using the same GPU runtime settings as when creating Media related dynamic mach-lookup extensions.
Attachments
Patch (2.62 KB, patch)
2020-10-08 14:13 PDT, Per Arne Vollan 		youennf: review+
DetailsFormatted DiffDiff
Patch (2.61 KB, patch)
2020-10-09 10:29 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2020-10-08 13:28:50 PDT
<rdar://problem/70066087>
Per Arne Vollan
Comment 2 2020-10-08 14:13:32 PDT
Created attachment 410882 [details] Patch
youenn fablet
Comment 3 2020-10-09 05:56:29 PDT
Comment on attachment 410882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410882&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:486 > + || !m_defaultPageGroup->preferences().captureVideoInGPUProcessEnabled() We can also capture in UIProcess, in which case we might not need the gpuIOKitExtensionHandles for capture purposes.
Per Arne Vollan
Comment 4 2020-10-09 10:29:06 PDT
Created attachment 410948 [details] Patch
Per Arne Vollan
Comment 5 2020-10-09 10:29:28 PDT
(In reply to youenn fablet from comment #3) > Comment on attachment 410882 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410882&action=review > > > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:486 > > + || !m_defaultPageGroup->preferences().captureVideoInGPUProcessEnabled() > > We can also capture in UIProcess, in which case we might not need the > gpuIOKitExtensionHandles for capture purposes. Thanks for reviewing! I have updated the patch.
EWS
Comment 6 2020-10-09 12:35:53 PDT
Committed r268278: <https://trac.webkit.org/changeset/268278> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410948 [details].
Note You need to log in before you can comment on or make changes to this bug.