Bug 217491 - [GPU Process] Use correct GPU runtime settings when creating the dynamic IOKit sandbox extensions for the WebContent process
Summary: [GPU Process] Use correct GPU runtime settings when creating the dynamic IOKi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-08 13:28 PDT by Per Arne Vollan
Modified: 2020-10-09 12:35 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.62 KB, patch)
2020-10-08 14:13 PDT, Per Arne Vollan 		youennf: review+
Details | Formatted Diff | Diff
Patch (2.61 KB, patch)
2020-10-09 10:29 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-10-08 13:28:14 PDT 
Currently, the creation of the dynamic IOKit sandbox extensions for the WebContent process is incorrectly using the same GPU runtime settings as when creating Media related dynamic mach-lookup extensions.
Comment 1 Per Arne Vollan 2020-10-08 13:28:50 PDT 
<rdar://problem/70066087>
Comment 2 Per Arne Vollan 2020-10-08 14:13:32 PDT 
Created attachment 410882 [details]
Patch
Comment 3 youenn fablet 2020-10-09 05:56:29 PDT 
Comment on attachment 410882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410882&action=review

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:486
> +        || !m_defaultPageGroup->preferences().captureVideoInGPUProcessEnabled()

We can also capture in UIProcess, in which case we might not need the gpuIOKitExtensionHandles for capture purposes.
Comment 4 Per Arne Vollan 2020-10-09 10:29:06 PDT 
Created attachment 410948 [details]
Patch
Comment 5 Per Arne Vollan 2020-10-09 10:29:28 PDT 
(In reply to youenn fablet from comment #3)
> Comment on attachment 410882 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=410882&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:486
> > +        || !m_defaultPageGroup->preferences().captureVideoInGPUProcessEnabled()
> 
> We can also capture in UIProcess, in which case we might not need the
> gpuIOKitExtensionHandles for capture purposes.

Thanks for reviewing! I have updated the patch.
Comment 6 EWS 2020-10-09 12:35:53 PDT 
Committed r268278: <https://trac.webkit.org/changeset/268278>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410948 [details].