Bug 217483

Summary: [macOS] Issue sandbox extension for icon service when attachment element is enabled
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Per Arne Vollan
Reported 2020-10-08 10:33:46 PDT
This has previously been done on iOS, and should be done on macOS as well.
Attachments
Patch (5.09 KB, patch)
2020-10-08 12:45 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (6.14 KB, patch)
2020-10-08 12:53 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (6.16 KB, patch)
2020-10-08 13:01 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-10-08 10:34:33 PDT
<rdar://problem/70099680>
Per Arne Vollan
Comment 2 2020-10-08 12:45:01 PDT
Created attachment 410873 [details] Patch
Per Arne Vollan
Comment 3 2020-10-08 12:53:50 PDT
Created attachment 410874 [details] Patch
Per Arne Vollan
Comment 4 2020-10-08 13:01:13 PDT
Created attachment 410875 [details] Patch
Brent Fulgham
Comment 5 2020-10-09 10:52:27 PDT
Comment on attachment 410875 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410875&action=review Nice harmonizing of the two platforms. r=me > Source/WebKit/Shared/WebPageCreationParameters.cpp:328 > +#endif Oh, oops! > Source/WebKit/UIProcess/WebProcessProxy.h:-364 > -#if ENABLE(ATTACHMENT_ELEMENT) && PLATFORM(IOS_FAMILY) Nice when everything is in sync!
Per Arne Vollan
Comment 6 2020-10-09 10:54:06 PDT
Comment on attachment 410875 [details] Patch Thanks for reviewing!
EWS
Comment 7 2020-10-09 11:07:52 PDT
Committed r268270: <https://trac.webkit.org/changeset/268270> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410875 [details].
Note You need to log in before you can comment on or make changes to this bug.