Bug 217469

Summary: Improve serialization of scroll-snap-type
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: CSSAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 217467    
Bug Blocks:    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Martin Robinson
Reported 2020-10-08 03:21:24 PDT
Since the default value for the second part of scroll-snap-type is "proximity" it should serialize to an empty string. This will fix a couple scroll snapping tests from the WPT suite.
Attachments
Patch (4.96 KB, patch)
2020-10-09 02:08 PDT, Martin Robinson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (17.18 KB, patch)
2020-10-09 04:36 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (18.12 KB, patch)
2020-10-12 01:08 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2020-10-09 02:08:56 PDT
Created attachment 410925 [details] Patch
Martin Robinson
Comment 2 2020-10-09 04:36:02 PDT
Created attachment 410930 [details] Patch
Simon Fraser (smfr)
Comment 3 2020-10-09 09:33:38 PDT
Comment on attachment 410930 [details] Patch Still one test failure.
Martin Robinson
Comment 4 2020-10-12 01:08:20 PDT
Created attachment 411101 [details] Patch
EWS
Comment 5 2020-10-12 01:46:01 PDT
Committed r268348: <https://trac.webkit.org/changeset/268348> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411101 [details].
Radar WebKit Bug Importer
Comment 6 2020-10-12 01:47:18 PDT
<rdar://problem/70198259>
Note You need to log in before you can comment on or make changes to this bug.