Bug 217469 - Improve serialization of scroll-snap-type
Summary: Improve serialization of scroll-snap-type
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
Keywords: InRadar
Depends on: 217467
  Show dependency treegraph
Reported: 2020-10-08 03:21 PDT by Martin Robinson
Modified: 2020-10-12 01:47 PDT (History)
10 users (show)

See Also:

Patch (4.96 KB, patch)
2020-10-09 02:08 PDT, Martin Robinson
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (17.18 KB, patch)
2020-10-09 04:36 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch (18.12 KB, patch)
2020-10-12 01:08 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2020-10-08 03:21:24 PDT
Since the default value for the second part of scroll-snap-type is "proximity" it should serialize to an empty string. This will fix a couple scroll snapping tests from the WPT suite.
Comment 1 Martin Robinson 2020-10-09 02:08:56 PDT
Created attachment 410925 [details]
Comment 2 Martin Robinson 2020-10-09 04:36:02 PDT
Created attachment 410930 [details]
Comment 3 Simon Fraser (smfr) 2020-10-09 09:33:38 PDT
Comment on attachment 410930 [details]

Still one test failure.
Comment 4 Martin Robinson 2020-10-12 01:08:20 PDT
Created attachment 411101 [details]
Comment 5 EWS 2020-10-12 01:46:01 PDT
Committed r268348: <https://trac.webkit.org/changeset/268348>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411101 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-12 01:47:18 PDT