Bug 217450

Summary: [LFC][Integration] Enable float clear for <br>
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

zalan
Reported 2020-10-07 14:39:09 PDT
ssia
Attachments
Patch (4.14 KB, patch)
2020-10-07 14:40 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (4.63 KB, patch)
2020-10-08 06:37 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (98.74 KB, patch)
2020-10-08 08:20 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2020-10-07 14:40:17 PDT
Created attachment 410783 [details] Patch
zalan
Comment 2 2020-10-07 21:02:13 PDT
So it looks like the floats placed in the FloatingObjects can return 2 different geometries. 1. if you check if there's a float on a particular vertical position the floored geometry is used (as the float is added with floored vertical position to the search tree), however 2. if you query for the bottom position of left/right/both to find a clear vertical position, the non-floored geometry is used. This is really hard to match in IFC since we only use _one_ geometry per box.
zalan
Comment 3 2020-10-08 06:37:34 PDT
Created attachment 410836 [details] Patch
zalan
Comment 4 2020-10-08 08:20:04 PDT
Created attachment 410840 [details] Patch
EWS
Comment 5 2020-10-08 12:29:28 PDT
Committed r268202: <https://trac.webkit.org/changeset/268202> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410840 [details].
Radar WebKit Bug Importer
Comment 6 2020-10-08 12:30:33 PDT
<rdar://problem/70105181>
Note You need to log in before you can comment on or make changes to this bug.