Summary: | [LFC][Integration] Enable float clear for <br> | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
zalan
2020-10-07 14:39:09 PDT
Created attachment 410783 [details]
Patch
So it looks like the floats placed in the FloatingObjects can return 2 different geometries. 1. if you check if there's a float on a particular vertical position the floored geometry is used (as the float is added with floored vertical position to the search tree), however 2. if you query for the bottom position of left/right/both to find a clear vertical position, the non-floored geometry is used. This is really hard to match in IFC since we only use _one_ geometry per box. Created attachment 410836 [details]
Patch
Created attachment 410840 [details]
Patch
Committed r268202: <https://trac.webkit.org/changeset/268202> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410840 [details]. |