Summary: | [CAIRO] RenderPath on SVG is incomplete. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||
Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | Cairo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Dirk Schulze
2008-10-19 10:59:11 PDT
Created attachment 24510 [details]
Completes RenderPath support for Cairo/SVG
This patch applies the stroke properties to the context and makes some optimizations.
Comment on attachment 24510 [details]
Completes RenderPath support for Cairo/SVG
Looks fine to me. Is WebKit GTK *still* not running DRT? If it is, this needs a test case. r- for lack of test case (or test case changes). But the code change itself looks fine.
(In reply to comment #2) > (From update of attachment 24510 [details] [edit]) > Looks fine to me. Is WebKit GTK *still* not running DRT? If it is, this needs > a test case. r- for lack of test case (or test case changes). But the code > change itself looks fine. There are already test cases in LayoutTests for this patch. strokeContains: LayoutTests/svg/custom/hit-test-path-stroke.svg strokeBBox: LayoutTests/svg/custom/stroked-pattern.svg strokeBBox is only used on SVG patterns with overflow="visible". Cairo lack's support for overflow="visible" currently. It is added with https://bugs.webkit.org/show_bug.cgi?id=21205. But it needs the patch for patterns on https://bugs.webkit.org/show_bug.cgi?id=21555 too. strokeBBox don't need the pattern patch: animate-elem-26-t.svg This test can be run by DRT now. But DRT has some problems on svg/custom/hit-test-path-stroke.svg for strokeContains. A problem on the DRT side. fixed by another patch |