Bug 217409

Summary: [webkitcorepy] Handle case where arguments to memoized function are lists
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED WONTFIX    
Severity: Normal CC: darin, dewei_zhu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216404
Attachments:
Description Flags
Patch darin: review+, jbedard: commit-queue+

Jonathan Bedard
Reported 2020-10-06 15:28:17 PDT
At the moment, we don't handle lists being passed to memoized functions.
Attachments
Patch (3.76 KB, patch)
2020-10-06 16:56 PDT, Jonathan Bedard 		darin: review+
jbedard: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-10-06 15:28:31 PDT
<rdar://problem/70020109>
Jonathan Bedard
Comment 2 2020-10-06 16:56:30 PDT
Created attachment 410714 [details] Patch
Jonathan Bedard
Comment 3 2020-10-07 11:27:12 PDT
Discussed this with Dean and Dewei, this case is a bit of a weird one because it handles what happens when someone passes a mutable argument to a memoized function. We're going to mark this as invalid and move on, the code change does what it says it does, it's just not obvious that behavior is more correct than the exception Python will raise.
Note You need to log in before you can comment on or make changes to this bug.