Bug 217399

Summary:

Move ownership of DownloadClient from WebProcessPool to DownloadProxy

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, cgarcia, ews-watchlist, gustavo, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	thorton: review+

Description Alex Christensen 2020-10-06 11:55:11 PDT

Move ownership of DownloadClient from WebProcessPool to DownloadProxy

Comment 1 Alex Christensen 2020-10-06 11:56:41 PDT

Created attachment 410674 [details]
Patch

Comment 2 EWS Watchlist 2020-10-06 11:57:29 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 Alex Christensen 2020-10-06 12:05:00 PDT

Created attachment 410676 [details]
Patch

Comment 4 Tim Horton 2020-10-06 12:34:33 PDT

Comment on attachment 410676 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410676&action=review

> Source/WebKit/ChangeLog:9
> +        This will allow us to get a DownloadClient from elswehere.

Probably should mention or link to or vaguely whisper about the reason/long term plan (even a related bugzilla bug)

Comment 5 Alex Christensen 2020-10-06 12:39:17 PDT

http://trac.webkit.org/r268065

Comment 6 Radar WebKit Bug Importer 2020-10-06 12:40:17 PDT

<rdar://problem/70011957>