| Summary: | MediaRecorder::create should not need to create a MediaRecorderPrivate to validate it can record properly | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2020-10-06 08:35:48 PDT
Created attachment 410741 [details]
Patch
Committed r268125: <https://trac.webkit.org/changeset/268125> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410741 [details]. A rebase of imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-detached-context.html is needed. Test is not passing yet but we should wait for https://github.com/w3c/mediacapture-record/issues/206 resolution. Reopening to attach new patch. Created attachment 410752 [details]
Test expectation update
Committed r268129: <https://trac.webkit.org/changeset/268129> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410752 [details]. Comment on attachment 410741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410741&action=review > Source/WebCore/ChangeLog:11 > + Remove assertion that we can create a private recorder in start since thgere is no guarantee that the frame might not be detached. s/thgere/there/ |