Bug 217383

Summary: Add support for MediaRecorder bitrate getters
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing none

youenn fablet
Reported 2020-10-06 06:43:52 PDT
Add support for MediaRecorder bitrate getters
Attachments
Patch (29.47 KB, patch)
2020-10-06 06:49 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (30.03 KB, patch)
2020-10-08 01:35 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (29.90 KB, patch)
2020-10-08 02:17 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.23 KB, patch)
2020-10-09 06:23 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-10-06 06:49:00 PDT
Created attachment 410630 [details] Patch
youenn fablet
Comment 2 2020-10-08 01:35:42 PDT
Created attachment 410817 [details] Patch
youenn fablet
Comment 3 2020-10-08 02:17:47 PDT
Created attachment 410820 [details] Patch
Alex Christensen
Comment 4 2020-10-08 07:56:26 PDT
Comment on attachment 410820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410820&action=review > Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.cpp:104 > + options.audioBitsPerSecond = 192000; Where do these numbers come from?
youenn fablet
Comment 5 2020-10-08 08:08:40 PDT
(In reply to Alex Christensen from comment #4) > Comment on attachment 410820 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410820&action=review > > > Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.cpp:104 > > + options.audioBitsPerSecond = 192000; > > Where do these numbers come from? The spec says to choose decent defaults. These are values for quality recording of audio and video. They could be set lower. Firefox is using 128kbps/2.5mbps which is not too far. Not sure about Chrome.
Eric Carlson
Comment 6 2020-10-09 06:00:51 PDT
Comment on attachment 410820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410820&action=review >>> Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.cpp:104 >>> + options.audioBitsPerSecond = 192000; >> >> Where do these numbers come from? > > The spec says to choose decent defaults. > These are values for quality recording of audio and video. > They could be set lower. > > Firefox is using 128kbps/2.5mbps which is not too far. Not sure about Chrome. It might be helpful for someone looking at this later to have a named constant. > Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.cpp:106 > + options.videoBitsPerSecond = 10000000; Ditto
youenn fablet
Comment 7 2020-10-09 06:23:55 PDT
Created attachment 410936 [details] Patch for landing
EWS
Comment 8 2020-10-12 07:00:02 PDT
commit-queue failed to commit attachment 410936 [details] to WebKit repository.
EWS
Comment 9 2020-10-12 10:42:20 PDT
Committed r268363: <https://trac.webkit.org/changeset/268363> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410936 [details].
Radar WebKit Bug Importer
Comment 10 2020-10-12 10:43:16 PDT
<rdar://problem/70213712>
Note You need to log in before you can comment on or make changes to this bug.