Bug 217375

Summary: Add support for MediaRecorder pause/resume
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 217379    
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2020-10-06 03:55:28 PDT
Add support for MediaRecorder pause/resume
Attachments
Patch (36.16 KB, patch)
2020-10-06 04:30 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (36.23 KB, patch)
2020-10-07 08:58 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-10-06 04:30:18 PDT
Created attachment 410624 [details] Patch
youenn fablet
Comment 2 2020-10-07 04:08:12 PDT
Comment on attachment 410624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410624&action=review > Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:243 > + return { }; We want to implement the latest spec changes which make pause be a no op except if state is recording. Plan is to do that as a follow-up for both pause and resume
Eric Carlson
Comment 3 2020-10-07 08:42:32 PDT
Comment on attachment 410624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410624&action=review > Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:237 > +ExceptionOr<void> MediaRecorder::pause() Tiny nit: "pauseRecording" would be more logical as it is symmetrical with resume.
youenn fablet
Comment 4 2020-10-07 08:58:37 PDT
Created attachment 410751 [details] Patch for landing
EWS
Comment 5 2020-10-07 09:41:56 PDT
Committed r268130: <https://trac.webkit.org/changeset/268130> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410751 [details].
Radar WebKit Bug Importer
Comment 6 2020-10-07 09:42:17 PDT
<rdar://problem/70051967>
Note You need to log in before you can comment on or make changes to this bug.