| Summary: | Add support for MediaRecorder pause/resume | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 217379 | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2020-10-06 03:55:28 PDT
Created attachment 410624 [details]
Patch
Comment on attachment 410624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410624&action=review > Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:243 > + return { }; We want to implement the latest spec changes which make pause be a no op except if state is recording. Plan is to do that as a follow-up for both pause and resume Comment on attachment 410624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410624&action=review > Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:237 > +ExceptionOr<void> MediaRecorder::pause() Tiny nit: "pauseRecording" would be more logical as it is symmetrical with resume. Created attachment 410751 [details]
Patch for landing
Committed r268130: <https://trac.webkit.org/changeset/268130> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410751 [details]. |